Review requests and actionable comments #418
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngested. This also fills in the "author_id" field for new commits.
…over the db commits (instead of Grit).
This just displays a list of commits that have unresolved comments.
…s that change state.
…osing, ...) to get correct styling.
… resolved comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My massive change is now ready for beta testing and review. Feel free to add comments and tweak stuff.
This change keeps track of review requests and "actionable" comments. Now you can see all the actions you need to take on one screen.
When someone requests that you review their commit, the request will show up in your "Code review requests" list.
When a reviewer adds a comment to a code review, it will show up on the commit author's "Actionable comments" list as "New". When the commit author resolves the comment (by clicking "Resolve" on the comment), then the comment will show up on the reviewer's "Actionable comments" list as "Resolved". The reviewer can then check that the comment was resolved to his satisfaction and delete it from his "Actionable comments" list or reopen it (by clicking the "Reopen" button on the comment).
Only comments marked as "Response requested" will show up in lists. (This naturally excludes all existing comments.) New comments will have the "Response requested" checkbox selected (unless it is a reply to another comment).
All the new lists are under a new major tab called "Reviews" at the top of the screen.
There are also other lists that are less commonly used and don't require action, that are collapsed by default. Those lists show: "Recently completed requests", "Code review requests (from me)", "Pending comments", and "Closed comments".