Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: Added a new props or a way to show selected filter. #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarangshahane
Copy link

Description

Hello @onesine & Team,

I am opening this PR to show the selected shortcut in the calendar dropdown. This is to make the date selector more UX-friendly so that users can see the selected shortcut/filter.

Here in this PR, I have added a way to show the selected shortcut in the calendar dropdown by comparing the stored value with the list of shortcodes.

The issue is reported here: #156


Here is the screenshot of the range filter after adding the class:

react-tailwindcss-datepicker


Note: Also, there were a few dependency issues while setting up the environment, the reason for them is mentioned below.

Reason for package.json file change

  • I am using a Windows system, and the command was not working, so, I had to make changes in the package.json file to commit the changes. Without running the command, I was not able to commit the changes.

Reason for .eslintrc.json file change.

  • The plugin:react-hooks/recommended is already available in the eslint-config-next/core-web-vitals due to which it was showing an error and was not allowing me to make a commit.

I hope this clarifies.

Please let me know if in case need more changes or discussion.

Looking forward to hearing from you.

@sarangshahane sarangshahane changed the title 🐛 Modified the npm packages to work on Windows system 🐛 Fix: Added a new props or a way to show selected filter. Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant