Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a new props or a way to show selected filter #156

Open
sarangshahane opened this issue Jul 3, 2023 · 4 comments
Open

Need a new props or a way to show selected filter #156

sarangshahane opened this issue Jul 3, 2023 · 4 comments

Comments

@sarangshahane
Copy link

Hello Team,

I hope you are doing well and okay.

I have been using this date picker for a long time and now, there is a need to display one filter to be selected once the date picker is opened.

  • Here is the screenshot of the range filter which needs modification:
    datepicker-range-filter

  • This is the screenshot of how it should be displayed when a particular date range is selected.:

    • UI of selected range filter with selected date:
      datepicker-range-filter-selected-filter

    • Classes added after selecting a specific date range filter:
      datepicker-range-filter-html-classes

Also following are a few conditions/suggestions that are good to have.

  • The filter should be selected if any of the mentioned filter's values is selected. Such as If today's date is set then the Today [The filter] should be chosen.
  • Also if there is an option/props made available to insert the user's custom classes when the filter is selected apart from he Default classes then that will be a good improvement.

I hope this clarifies the requirement and current limitations of the component.

Please let me know if in case you require more information.

Looking forward to try this as soon as possible.

@sarangshahane
Copy link
Author

@onesine Any comments on this would be appreciated..

@onesine
Copy link
Owner

onesine commented Jul 18, 2023

Hi 👋 @sarangshahane

So sorry for the delay in responding.

I'm doing my best to address everyone's concerns. Lately I've been quite busy with work, but I'll deal with your issue as soon as possible.

All PRs are welcome.

@sarangshahane
Copy link
Author

@onesine I have opened the PR for this change.

Here is the PR: #187

Looking forward to your feedback.

@sarangshahane
Copy link
Author

Hello @onesine ,

Is there any update on this? It's been a year after openng a this PR and issue..

Looking forward to hearing from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants