[L0] Interrupt-based event implementation #2334
Open
+263
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
winstonzhang-intel
force-pushed
the
interrupt-based
branch
from
4af82e7
to
b063947
Compare
To expose this functionality in UR, we want two ways of enabling low-power events: Queue-wide enabling so all events created on the queue are low-powered. As a property passed to urEnqueueEventsWaitWithBarrier making the resulting event a low-power event. This will require the existing interface to be extended with properties, potentially through a new experimental function. Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
force-pushed
the
interrupt-based
branch
from
7835bc8
to
28e7d38
Compare
Signed-off-by: Zhang, Winston <[email protected]>
EwanC
reviewed
Nov 22, 2024
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
pbalcer
approved these changes
Nov 27, 2024
| bool InterruptBased = | ||
| EnqueueExtProp && | ||
| (EnqueueExtProp->flags & UR_EXP_ENQUEUE_EXT_FLAG_LOW_POWER_EVENTS); | ||
| if (InterruptBased) { |
There was a problem hiding this comment.
I'm not sure I understand the intention here or why we need to cast the function.
| ur_queue_handle_t, uint32_t, const ur_event_handle_t *, | ||
| ur_event_handle_t *, bool)>(EnqueueEventsWaitWithBarrier)( | ||
| Queue, NumEventsInWaitList, EventWaitList, OutEvent, | ||
| Queue ? Queue->InterruptBasedEventsEnabled : false); |
There was a problem hiding this comment.
Queue ? Queue->InterruptBasedEventsEnabled : false
I don't believe Queue can be null here. So this should be simply InterruptBased || Queue->InterruptBasedEventsEnabled.
| @@ -574,6 +583,9 @@ ur_event_handle_t ur_context_handle_t_::getEventFromContextCache( | |||
| if (Event->CounterBasedEventsEnabled != CounterBasedEventEnabled) { | |||
| return nullptr; | |||
| } | |||
| if (Event->InterruptBasedEventsEnabled != InterruptBasedEventEnabled) { | |||
There was a problem hiding this comment.
This will not work unless the interrupt based events are somehow first on the Cache container. The same is true of the counter-based events. There needs to be separate pool for interrupt-driven events (or maybe they shouldn't be cached at all?).
| HostVisibleInterruptAndCounterBasedRegularCacheType, | ||
| HostInvisibleInterruptAndCounterBasedRegularCacheType, | ||
| HostVisibleInterruptAndCounterBasedImmediateCacheType, | ||
| HostInvisibleInterruptAndCounterBasedImmediateCacheType |
There was a problem hiding this comment.
This is exactly why I've asked you to do the refactor. This will grow exponentially with new event parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To expose this functionality in UR, we want two ways of enabling low-power events: