Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting UsersCreation.cy.ts according to POM approach #8930

Merged
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
e98e99f
removed ClickElementById function from UsersCreation.cy.ts
AnveshNalimela Oct 25, 2024
5479921
Update .env
AnveshNalimela Oct 27, 2024
d47a676
Removed ClickELementById from userCreation.ts
AnveshNalimela Oct 27, 2024
a1ac783
updated .env
AnveshNalimela Oct 27, 2024
b4d9129
Merge branch 'remove-clickElementById/#8929' of https://github.com/An…
AnveshNalimela Oct 27, 2024
2d81b26
Added functions in pageobject/usercreation.ts according to POM approch
AnveshNalimela Oct 27, 2024
086eb6b
Rewrite user creation.cy.ts
AnveshNalimela Oct 28, 2024
daa6deb
Resloving conflicts
AnveshNalimela Nov 1, 2024
5ac2a1c
Finsihed Writing UserCreation.cy.ts
AnveshNalimela Nov 1, 2024
8f98d25
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 2, 2024
5deaa38
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 4, 2024
21fb0b2
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 5, 2024
6e78b30
clear and type functions are defined
AnveshNalimela Nov 5, 2024
012f68e
trying to reslove
AnveshNalimela Nov 7, 2024
b075b33
Merge branch 'ohcnetwork:develop' into remove-clickElementById/#8929
AnveshNalimela Nov 8, 2024
057f1e2
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 8, 2024
9a0a15e
Merge branch 'remove-clickElementById/#8929' of https://github.com/An…
AnveshNalimela Nov 8, 2024
b7950cd
Merge branch 'develop' into remove-clickElementById/#8929
nihal467 Nov 8, 2024
7aaa96a
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 9, 2024
d231102
made changes mentioned by coderrabit
AnveshNalimela Nov 10, 2024
b3850f2
Merge branch 'ohcnetwork:develop' into remove-clickElementById/#8929
AnveshNalimela Nov 10, 2024
4cdbdfa
ALtPhoneNumber function crrrected
AnveshNalimela Nov 10, 2024
908926e
Merge branch 'remove-clickElementById/#8929' of github.com:AnveshNali…
AnveshNalimela Nov 10, 2024
289421e
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 11, 2024
fcceae4
made few changes suggested by coderrabit
AnveshNalimela Nov 11, 2024
926535d
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 13, 2024
9ab927a
made requested changes
AnveshNalimela Nov 13, 2024
54e9abe
Merge branch 'develop' into remove-clickElementById/#8929
AnveshNalimela Nov 15, 2024
c021f4e
PhoneNumber changes revered
AnveshNalimela Nov 15, 2024
6a56e6f
Merge branch 'develop' into remove-clickElementById/#8929
nihal467 Nov 18, 2024
f70faa3
Merged into develop
AnveshNalimela Nov 26, 2024
54b420f
Merge branch 'remove-clickElementById/#8929' of github.com:AnveshNali…
AnveshNalimela Nov 26, 2024
92fde8b
Made requested changes
AnveshNalimela Nov 26, 2024
8a7b927
Merge branch 'ohcnetwork:develop' into remove-clickElementById/#8929
AnveshNalimela Nov 26, 2024
e735efa
made suggestions from the code rabbit
AnveshNalimela Nov 26, 2024
535e641
Merge branch 'remove-clickElementById/#8929' of github.com:AnveshNali…
AnveshNalimela Nov 26, 2024
b51a349
updated package-lock.json
AnveshNalimela Nov 26, 2024
3593709
Merge branch 'ohcnetwork:develop' into remove-clickElementById/#8929
AnveshNalimela Nov 27, 2024
0c5135f
fix line endings
rithviknishad Nov 28, 2024
ad5da79
coderabbit suggestions
nihal467 Nov 29, 2024
66c8064
number variable modified
nihal467 Nov 29, 2024
cd7c551
removed hard code
nihal467 Nov 29, 2024
360c540
secure the phone number generation
nihal467 Nov 29, 2024
e24c032
add missing # to id
nihal467 Nov 29, 2024
bacfc8a
Merge branch 'develop' into remove-clickElementById/#8929
nihal467 Nov 29, 2024
185e6f3
modified the bed name
nihal467 Nov 29, 2024
5bf8c5d
Merge branch 'remove-clickElementById/#8929' of https://github.com/An…
nihal467 Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed ClickELementById from userCreation.ts
  • Loading branch information
AnveshNalimela committed Oct 27, 2024
commit d47a6767d52dbe4556f88e179cb1a296c97be0be
4 changes: 2 additions & 2 deletions cypress/e2e/users_spec/UsersCreation.cy.ts
AnveshNalimela marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -140,7 +140,7 @@ describe("User Creation", () => {
});

it("create new user and verify reflection", () => {
userCreationPage.clickElementById("addUserButton");
cy.get("#addUserButton").click();
userCreationPage.selectFacility("Dummy Shifting Center");
userCreationPage.typeIntoElementById("username", username);
userCreationPage.typeIntoElementById("password", "Test@123");
AnveshNalimela marked this conversation as resolved.
Show resolved Hide resolved
@@ -161,7 +161,7 @@ describe("User Creation", () => {
userCreationPage.selectDropdownOption("gender", "Male");
userCreationPage.selectDropdownOption("state", "Kerala");
userCreationPage.selectDropdownOption("district", "Ernakulam");
userCreationPage.clickElementById("submit");
cy.get("#submit").click();
userCreationPage.verifyNotification("User added successfully");
userPage.typeInSearchInput(username);
userPage.checkUsernameText(username);
10 changes: 3 additions & 7 deletions cypress/pageobject/Users/UserCreation.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
// UserCreation.ts
export class UserCreationPage {
clickElementById(elementId: string) {
cy.get("#" + elementId).click();
}

typeIntoElementById(elementId: string, value: string) {
cy.get("#" + elementId)
.click()
@@ -50,7 +46,7 @@ export class UserCreationPage {
}

selectHomeFacility(name: string) {
this.clickElementById("home_facility");
cy.get("#home_facility").click();
this.selectOptionContainingText(name);
}

@@ -59,12 +55,12 @@ export class UserCreationPage {
inputElementId: string,
dateValue: string,
) {
this.clickElementById(dateElementId);
cy.get("#" + dateElementId).click();
AnveshNalimela marked this conversation as resolved.
Show resolved Hide resolved
this.typeIntoElementById(inputElementId, dateValue);
}

selectDropdownOption(dropdownId: string, optionText: string) {
this.clickElementById(dropdownId);
cy.get("#" + dropdownId).click();
AnveshNalimela marked this conversation as resolved.
Show resolved Hide resolved
this.selectOptionContainingText(optionText);
}