Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified bed creation notification to show proper action-related message #8627 #8631

Closed
wants to merge 2 commits into from
Closed

fix: modified bed creation notification to show proper action-related message #8627 #8631

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041b8cd
fix: modify bed creation notification to show proper action-related m…
syedfardeenjeelani Sep 26, 2024
e10ba1a
Update AddBedForm.tsx
syedfardeenjeelani Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Components/Facility/AddBedForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,13 @@ export const AddBedForm = ({ facilityId, locationId, bedId }: Props) => {
res?.ok && onSuccess("Bed updated successfully");
} else {
// Create

const { res } = await request(routes.createFacilityBed, {
body: { ...data, facility: facilityId, location: locationId },
});
res?.ok && onSuccess("Bed(s) created successfully");
res?.ok && numberOfBeds > 1
? onSuccess("Bed(s) created successfully")
: onSuccess("Bed created successfully");
Comment on lines +131 to +133
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep representable texts in en locale files using useTranslations.

Also check-out the proper expected behaviour. Show "Beds" instead of "Bed(s)" for multiple bed creation.

}
};

Expand Down
Loading