fix: modified bed creation notification to show proper action-related message #8627 #8631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
syedfardeenjeelani
changed the title
Removed console.log from the file
rithviknishad
requested changes
Sep 26, 2024
There was a problem hiding this comment.
@syedfardeenjeelani Kindly request for issues to be assigned before working on them, so that it can be assigned to you and others who are trying to pick them up knows that someone else is already working on it.
Please do comment on the issue now too, so that it can be assigned.
Comment on lines
+131
to
+133
| res?.ok && numberOfBeds > 1 | ||
| ? onSuccess("Bed(s) created successfully") | ||
| : onSuccess("Bed created successfully"); |
There was a problem hiding this comment.
Let's keep representable texts in en locale files using useTranslations.
Also check-out the proper expected behaviour. Show "Beds" instead of "Bed(s)" for multiple bed creation.
|
Closing as duplicate of #8632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: modify bed creation notification to show proper action-related message #8627
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Here is a screenshot of the fix: