Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor care config to use camelCase variables and remove useConfig hook #8450

Merged
merged 4 commits into from
Sep 1, 2024

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Aug 31, 2024

Proposed Changes

  • Refactor care.config.ts to use camelCase variables
  • Removed useConfig hook

@ohcnetwork/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner August 31, 2024 06:48
Copy link

vercel bot commented Aug 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2024 9:55am

@rithviknishad rithviknishad requested review from bodhish, gigincg, khavinshankar, sainak and shivankacker and removed request for a team August 31, 2024 06:51
@rithviknishad rithviknishad changed the title Refactor care config to use camel case and remove useConfig hook Refactor care config to use camelCase variables and remove useConfig hook Aug 31, 2024
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +20 to +24
# Main logo (JSON string with light and dark properties)
REACT_HEADER_LOGO=

# Main logo (JSON string with light and dark properties)
REACT_MAIN_LOGO=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add examples when the we are expecting structures.

@bodhish bodhish merged commit 5d689cd into add-api-url Sep 1, 2024
10 checks passed
@bodhish bodhish deleted the rithviknishad/fix/camelCase-config branch September 1, 2024 07:29
Copy link

github-actions bot commented Sep 1, 2024

@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants