Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proxy and clean up config #8445

Merged
merged 16 commits into from
Sep 3, 2024
Merged

Remove proxy and clean up config #8445

merged 16 commits into from
Sep 3, 2024

Conversation

bodhish
Copy link
Member

@bodhish bodhish commented Aug 30, 2024

Proposed Changes

  • Load config from env with defaults
  • Remove proxy and direclty call the backend api

@ohcnetwork/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@bodhish bodhish requested a review from a team as a code owner August 30, 2024 15:19
@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 7:38pm

@bodhish bodhish requested a review from gigincg August 30, 2024 15:19
@netlify Netlify
Copy link

netlify bot commented Aug 30, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 91801da
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66d74e84e45daa0008172049
😎 Deploy Preview https://deploy-preview-8445--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish bodhish requested a review from rithviknishad August 30, 2024 15:19
rithviknishad
rithviknishad reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we switch to camelCase?

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 31, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @bodhish,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad
Copy link
Member

Should we switch to camelCase?

@bodhish Raised a PR for the same with base branch as this PR's branch: #8450

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 1, 2024
@rithviknishad rithviknishad self-assigned this Sep 2, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

👋 Hi, @bodhish,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Sep 2, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Sep 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

👋 Hi, @bodhish,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Sep 2, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 3, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit f3393fb
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66d7119f63f74b0008d0c9a2

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Sep 3, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Sep 3, 2024
khavinshankar
khavinshankar reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add i18n for kasp string if it differs for each language

care.config.ts Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
vite.config.mts Show resolved Hide resolved
src/vite-env.d.ts Show resolved Hide resolved
@bodhish
Copy link
Member Author

bodhish commented Sep 3, 2024

  • Add i18n for kasp string if it differs for each language

@khavinshankar The KASP string is a tricky variable, this was added for the covid times, it more like a state run insurance provider, since we have a better way to capture insurance now, we would phase out the KASP variable. So lets not support internationalisation for that for now.

bodhish
bodhish commented Sep 3, 2024
View reviewed changes
care.config.ts Show resolved Hide resolved
bodhish
bodhish commented Sep 3, 2024
View reviewed changes
care.config.ts Show resolved Hide resolved
bodhish
bodhish commented Sep 3, 2024
View reviewed changes
care.config.ts Show resolved Hide resolved
index.html Show resolved Hide resolved
@rithviknishad rithviknishad mentioned this pull request Sep 3, 2024
Closed
3 tasks
@khavinshankar khavinshankar merged commit 28b02d9 into develop Sep 3, 2024
31 checks passed
@khavinshankar khavinshankar deleted the add-api-url branch September 3, 2024 18:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

@rithviknishad @bodhish Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

sainak
sainak reviewed Sep 4, 2024
View reviewed changes
care.config.ts
@@ -0,0 +1,103 @@
const env = import.meta.env;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak left review comments

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

@shivankacker shivankacker Awaiting requested review from shivankacker

Assignees

@rithviknishad rithviknishad

Labels
needs review
Projects
Care
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bodhish @rithviknishad @khavinshankar @sainak