Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to care config #8470

Closed
3 tasks
rithviknishad opened this issue Sep 3, 2024 · 4 comments · Fixed by #9032
Closed
3 tasks

Enhancements to care config #8470

rithviknishad opened this issue Sep 3, 2024 · 4 comments · Fixed by #9032
Assignees
Labels

Comments

@rithviknishad
Copy link
Member

#8445 Introduces care.config.ts for making CARE configurable from ENVs. However there are couple of enhancements that can be done:

  • Perform config validation during vite build so that build fails thus preventing exceptions from being thrown during runtime if any.
  • Sentry config to be optional and enable sentry only if configured.
  • Plausible config to be optional and enable plausible only if configured.
@rithviknishad rithviknishad added the waiting for related PR a co-related detail PR is under construction label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to Triage in Care Sep 3, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Sep 3, 2024
@rithviknishad rithviknishad removed the waiting for related PR a co-related detail PR is under construction label Sep 3, 2024
@github-actions github-actions bot added the stale label Sep 18, 2024
@bodhish bodhish added good first issue Good for newcomers and removed stale labels Sep 18, 2024
@Deexit1
Copy link

Deexit1 commented Oct 2, 2024

@bodhish / @rithviknishad I will be able to complete the 2nd and 3rd task e.g., optional plugins based on provided config.

Need Clarification:
For the first task, which kind of config validations are required for each config option ? Also, should we use any schema validation libraries like zod ?

@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Oct 15, 2024

Vite's community plugins includes two env validation plugins, one of which supports Yup/Zod etc. So, we could make use of that, or build one ourselves.

@github-actions github-actions bot added the stale label Oct 30, 2024
@Alokih
Copy link

Alokih commented Nov 6, 2024

@Jacobjeevan , @rithviknishad can I work on this issue ?

@Alokih
Copy link

Alokih commented Nov 6, 2024

@Jacobjeevan sir, I have created a PR can you review it once , I have just added validation for only 5 env , should I add more ?

@Jacobjeevan Jacobjeevan moved this from Up Next to Review required in Care Nov 7, 2024
@Jacobjeevan Jacobjeevan moved this from Review required to In Progress in Care Nov 7, 2024
@github-actions github-actions bot removed the stale label Nov 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Care Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
5 participants