Fix stretching issue in comment section on shifting detail page #7364
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanush19
changed the title
|
hey @rithviknishad , i haved renamed the PR and Issue i have resolved is Comment Section in the shifting detail page is stretching the page #6637 ( #6637) |
Thanush19
changed the title
For example, see: #7358 |
|
Doing so will cause the PR to be linked to the issue and once the PR is merged, issue gets closed automatically. |
|
I think we should publish a small section in the readme about commit messages; |
Thanush19
changed the title
Thanush19
changed the title
|
is the PR title is okay now , if any changes need to be done , intimate me @rithviknishad ... |
rithviknishad
changed the title
| id: string; | ||
| comment: string; | ||
| created_by_object: any; |
There was a problem hiding this comment.
Can we have proper types here? We have a pre-defined type: "PerformedByUserModel" which can be used here.
There was a problem hiding this comment.
The 'PerformedByUserModel' interface does not have the required type that I need for the 'commentSection', so I can't use it here. Therefore, I defined a new interface.
export type UserBareMinimum = {
id: number;
username: string;
first_name: string;
last_name: string;
email: string;
user_type: UserRole;
last_login: string | undefined;
};
interface CommentProps {
id: string;
comment: string;
created_by_object: any;
modified_date: string;
}
There was a problem hiding this comment.
It was already type-safe before you did the modifications. You've removed the types...
| <p className="text-justify"> | ||
| {expanded ? comment : truncatedComment} | ||
| {!expanded && remainingComment && ( | ||
| <button onClick={toggleExpanded} className="ml-2 text-green-600"> |
There was a problem hiding this comment.
Use primary color instead of green
|
@Thanush19 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
|
Closing as duplicate of #7402 |
I have realigned the UI of the shift page and also added a "Read More" and "Read Less" option for comments with more than 30 words.
Closes #6637