Comment Section in the shifting detail page is stretching the page

[nihal467]

Describe the bug

When we post multiple comment on a shifting detail page, it keep on stretching the page to the bottom

To Reproduce
Steps to reproduce the behavior:

1. Go to any existing shifting detail page and post multiple comments ( https://care.coronasafe.in/shifting/e785d651-9fde-4279-ac33-e9282296dc10 )
2. See error

Expected behavior

It shouldn't be stretching the page a lot and the entire page should be effectively utilizing the white space

Screenshots

[parthksingh1]

@rithviknishad Please assign me this issue .To resolve the bug, I will inspect and adjust the CSS styles associated with the comment section on shifting detail pages, ensuring responsive design and dynamic sizing. Will Thoroughly test the changes with different comment quantities and devices to ensure optimal page layout

[konavivekramakrishna]

@rithviknishad

A simple solution would be to passing perPage 5 or 6. by default per Page is 14, causing the entire page to stretch significantly

[Bhavik-ag]

@rithviknishad @nihal467 Here are two simple possible solutions

1. We can shift the patient details section to the right side of grid and setting comment perPage limit to 5.

2. We can make patient details page expand full width and comments and rest section side by side.

[rishbanerjee]

Hey @rithviknishad @nihal467 I tried to see this error on the webpage but when I try to post a comment it shows an error "Not found" , is this issue still relevant?

[senthil-athiban]

Hey @nihal467. We can enhance the user experience by adding a view more button. Based on that, when the user clicks on it, an extra 5 more comments will be visible, and we'll repeat the same until the comment exists. And intially Top 5 comments will be only displayed.

[Thanush19]

Hey, if the issue is not completed, I can work on this.

[Thanush19]

Shifting.details._.CARE.mp4

i have submitted my PR #7364, kindly review it , if any changes need to be done , intimate me @rithviknishad

[Thanush19]

@rithviknishad , is there any corrections needed to be done ? if so, intimate me...?

[Thanush19]

@rithviknishad , whats the status on this PR?? is any changes required...

[rithviknishad]

Hey, not sure if you've missed it, but I've requested changes in your PR two days ago

[Thanush19]

@rithviknishad You instructed me to reuse the existing type, but it lacks the required types for comments. Additionally, you mentioned reusing the ReadMore.tsx component, but when I attempt to do so, it doesn't align with the Comment Box. Modifying the CSS of the ReadMore component might disrupt the UI of other components, so I opted to write new code to address this issue.

[rithviknishad]

Alright. ReadMore component is fine.

But any type is not allowed when we already have types for it.

If you look carefully, proper types are already present for created_by_object in the same file too. You just have to re-use it.

[Thanush19]

@rithviknishad , i've submitted new PR ,correcting all the changes u asked for , and also added Multilingual support for all the Button i have used , check my PR #7402

[Thanush19]

hey @rithviknishad , whats the status on my PR....

[nihal467]

@Thanush19 Unassigning you from this issue due to inactivity. Feel free to reassign yourself if you are still working on it.

[NikhilGolla72]

@rithviknishad hello,is this issue still open? if yes, I would like to work on this issue.

[Jacobjeevan]

Holding this on the back burner now, as shifting details page might get redesigned (as grid/table format). If so, could redesign this page along with that 🤔