Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Inline view of selected options of Multiselect #7287

Merged

Conversation

creator79
Copy link
Contributor

@creator79 creator79 commented Feb 27, 2024

Proposed Changes

Implement showing the selected options within the input itself. Overflowing chips could be wrapped in a new line within the input itself or be horizontally scrollable in one line. Additionally, each chip could optionally have a remove button to the right of it.

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@creator79 creator79 requested a review from a team as a code owner February 27, 2024 09:40
Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 4:56pm

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 44d3fa7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e74e7b29572200095739bc
😎 Deploy Preview https://deploy-preview-7287--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a minor suggestion, can we decrease the padding when an item is selected, so that it looks consistent in size with other types input fields?

@creator79
Copy link
Contributor Author

creator79 commented Feb 27, 2024

@rithviknishad please review it once i m just fix it padding to look more consistent ui

image

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khavinshankar khavinshankar merged commit 990dca9 into ohcnetwork:develop Mar 5, 2024
19 of 25 checks passed
Copy link

github-actions bot commented Mar 5, 2024

@Ashesh3 @khavinshankar @creator79 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline view of selected options of Multiselect
5 participants