Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline view of options missing for AutocompleteMultiSelectFormField #7382

Closed
rithviknishad opened this issue Mar 11, 2024 · 13 comments
Closed
Assignees
Labels
good first issue Good for newcomers stale

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Mar 11, 2024

Describe the bug
#7287 has introduced support for an inline view of selected options for "MultiSelectFormField". However, the same is not present for AutocompleteMultiSelectFormField and hence makes the UI inconsistent.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a place where AutocompleteMultiSelectFormField is used (for example Log Lab Results page)

Expected behavior
The UI should be similar to the inline view that MultiSelectFormField provides.

Screenshots

Current:
image

Expected:
image

@github-project-automation github-project-automation bot moved this to Triage in Care Mar 11, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Mar 11, 2024
@rithviknishad rithviknishad added the good first issue Good for newcomers label Mar 11, 2024
@Shahbaz898414
Copy link

Shahbaz898414 commented Mar 11, 2024

@rithviknishad plz assign me?

@Sulochan-khadka
Copy link
Contributor

Is this issue still in progress? @rithviknishad .
@Shahbaz898414 in case you are stuck somewhere, let me know where can I help you fix this issue.

@thedevildude
Copy link
Contributor

@rithviknishad I'd like to work on it if it's still open

@Sulochan-khadka
Copy link
Contributor

Dear @Shahbaz898414 , kindly do not halt the solution to this issue. If you are stuck somewhere, let me know if I can help. Also if you want , I can give you the idea or rather the initial approach to solve this issue.

@Shahbaz898414
Copy link

Dear @Shahbaz898414 , kindly do not halt the solution to this issue. If you are stuck somewhere, let me know if I can help. Also if you want , I can give you the idea or rather the initial approach to solve this issue.

I apologize for the delay. Please grant me some additional time to work on this.

@Sulochan-khadka
Copy link
Contributor

Dear @Shahbaz898414 , kindly do not halt the solution to this issue. If you are stuck somewhere, let me know if I can help. Also if you want , I can give you the idea or rather the initial approach to solve this issue.

I apologize for the delay. Please grant me some additional time to work on this.

Sure... No issues . Just let me know if you get stuck somewhere.

@Shahbaz898414
Copy link

Shahbaz898414 commented Mar 31, 2024

Dear @Shahbaz898414 , kindly do not halt the solution to this issue. If you are stuck somewhere, let me know if I can help. Also if you want , I can give you the idea or rather the initial approach to solve this issue.

I apologize for the delay. Please grant me some additional time to work on this.

Sure... No issues . Just let me know if you get stuck somewhere.

bro can you provide your linkedin plz ?

@ankitmrj
Copy link

ankitmrj commented Apr 1, 2024

@rithviknishad sir if issue is still not resolved, can I work on it?

@Sulochan-khadka
Copy link
Contributor

Dear @Shahbaz898414 , kindly do not halt the solution to this issue. If you are stuck somewhere, let me know if I can help. Also if you want , I can give you the idea or rather the initial approach to solve this issue.

I apologize for the delay. Please grant me some additional time to work on this.

Sure... No issues . Just let me know if you get stuck somewhere.

bro can you provide your linkedin plz ?

sure... www.linkedin.com/in/sulochan-khadka here you go...

Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

@github-actions github-actions bot added the stale label Apr 18, 2024
@Sulochan-khadka
Copy link
Contributor

@rithviknishad this has been solved by probably two ways. Since Combobox.input does not explicitly support this type of styling , 2 ways seemed to me to get it solved. The easiest way to get this solved was to use any pre-worked feature / library (increasing dependencies), while the other way round was to create from scratch, by working on the stylings , modifying some, and then achieving the required. Do let me know which one to push. I prefer the latter one since combobox consistency will be preserved along with no increase in dependency.

@github-actions github-actions bot removed the stale label Apr 27, 2024
@github-actions github-actions bot added the stale label Aug 16, 2024
@Utkarsh-Anandani
Copy link

Is the issue still open

@rithviknishad
Copy link
Member Author

Closing as we are switching to use shadcn's components

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stale
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants