Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect error message for invalid QR code #7588

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Fix Incorrect error message for invalid QR code #7588

merged 12 commits into from
Aug 1, 2024

Conversation

AnkurPrabhu
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

SS:
Screenshot 2024-04-12 at 1 36 44 AM

@AnkurPrabhu AnkurPrabhu requested a review from a team as a code owner April 11, 2024 20:14
@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024

@AnkurPrabhu is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 25ab42a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66aa47af280a2700085a1280
😎 Deploy Preview https://deploy-preview-7588--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish
bodhish requested changes Apr 15, 2024
View reviewed changes
src/Components/Assets/AssetsList.tsx Outdated
}
setIsLoading(false);
Notification.Error({ msg: "Invalid Asset Id" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make the message more friendly;

Example

Oops! The asset ID you entered does not appear to be valid.

Also lets keep all strings in I18n

@AnkurPrabhu
Copy link
Contributor Author

AnkurPrabhu commented Apr 17, 2024 •
edited
Loading

@bodhish i have updated the pr

rithviknishad
rithviknishad requested changes Apr 21, 2024
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings not present in i18n files.

@rithviknishad
Copy link
Member

Refer: #4467

@AnkurPrabhu AnkurPrabhu mentioned this pull request Apr 25, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 29, 2024
@AnkurPrabhu AnkurPrabhu force-pushed the fix-bug-qr-scanner branch from 1294f88 to 5292ed9 Compare May 4, 2024 10:50
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

👋 Hi, @AnkurPrabhu,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented May 7, 2024

@AnkurPrabhu clear the merge conflict

CC: @rithviknishad

@nihal467
Copy link
Member

@AnkurPrabhu remove the additional "something went wrong...!" error message , when we scan invalid QR

image

@AnkurPrabhu AnkurPrabhu force-pushed the fix-bug-qr-scanner branch from df52c9c to c055554 Compare May 22, 2024 14:08
@AnkurPrabhu
Copy link
Contributor Author

@rithviknishad can you tell me if my approach is correct ?

@github-actions GitHub Actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale merge conflict pull requests with merge conflict labels May 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

👋 Hi, @AnkurPrabhu,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467 nihal467 removed the stale label Jul 30, 2024
@nihal467
Copy link
Member

LGTM @khavinshankar can you resolve the merge conflict and merge it

@netlify Netlify
Copy link

netlify bot commented Jul 31, 2024

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit d4833c6
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66aa3f1c6bb59d000857d6ec

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Jul 31, 2024
@khavinshankar khavinshankar requested a review from bodhish July 31, 2024 13:57
@khavinshankar khavinshankar removed Deploy-Failed Deplyment is not showing preview merge conflict pull requests with merge conflict labels Jul 31, 2024
@nihal467
Copy link
Member

nihal467 commented Aug 1, 2024

LGTM

@gigincg gigincg merged commit d70b99a into ohcnetwork:develop Aug 1, 2024
28 of 29 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

@AnkurPrabhu Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to Scan The QR Code in Asset Module
6 participants
@AnkurPrabhu @rithviknishad @nihal467 @bodhish @khavinshankar @gigincg