Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify QR code error notification #7708

Closed
2 tasks
nihal467 opened this issue Apr 25, 2024 · 3 comments · Fixed by #7726
Closed
2 tasks

Modify QR code error notification #7708

nihal467 opened this issue Apr 25, 2024 · 3 comments · Fixed by #7726

Comments

@nihal467
Copy link
Member

Describe the bug

  • When we scan a valid QR Code but that asset is not accessible with my user-id privilege, the error throw is "Something went wrong"

To Reproduce
Steps to reproduce the behavior:

  1. Go to the asset tab and scan a QR code
  2. See error

Expected behavior

  • show the proper notification for the above-mentioned scenario

Screenshots

image

image

@AshrafMd-1
Copy link
Contributor

@nihal467 can you assign me this issue

@AshrafMd-1
Copy link
Contributor

Actually, the problem here is that when you search for the non authorized qr you get like an error

image

that's the reason it shows something went wrong

but how about from the backend we display a non-authorized message so we can directly implement it here

@AshrafMd-1
Copy link
Contributor

image

This is how i have handled it

if its okay i will make a PR

AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue May 1, 2024
nihal467 added a commit to AshrafMd-1/care_fe that referenced this issue May 7, 2024
AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue May 13, 2024
AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue May 17, 2024
AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue May 21, 2024
AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue May 22, 2024
AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue May 29, 2024
AshrafMd-1 added a commit to AshrafMd-1/care_fe that referenced this issue Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants