Fix Incorrect error message for invalid QR code (#7588)

ohcnetwork · Aug 1, 2024 · d70b99a · d70b99a
1 parent f4e2e39
commit d70b99a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/Components/Assets/AssetsList.tsx b/src/Components/Assets/AssetsList.tsx
@@ -121,7 +121,7 @@ const AssetsList = () => {
       if (!isValidURL(assetURL)) {
         setIsLoading(false);
         Notification.Error({
-          msg: "Invalid QR code scanned !!!",
+          msg: t("invalid_asset_id_msg"),
         });
         return;
       }
@@ -137,7 +137,7 @@ const AssetsList = () => {
         if (!data) {
           setIsLoading(false);
           Notification.Error({
-            msg: "Invalid QR code scanned !!!",
+            msg: t("invalid_asset_id_msg"),
           });
           return;
         }
@@ -151,17 +151,22 @@ const AssetsList = () => {
         } else {
           setIsLoading(false);
           Notification.Error({
-            msg: "Asset not found !!!",
+            msg: t("asset_not_found_msg"),
           });
         }
       } else {
         setIsLoading(false);
         Notification.Error({
-          msg: "Invalid QR code scanned !!!",
+          msg: t("invalid_asset_id_msg"),
         });
       }
     } catch (err) {
       console.log(err);
+      Notification.Error({
+        msg: t("invalid_asset_id_msg"),
+      });
+    } finally {
+      setIsLoading(false);
     }
   };
 

diff --git a/src/Locale/en/Notifications.json b/src/Locale/en/Notifications.json
@@ -16,5 +16,7 @@
   "unsubscribe_failed": "Unsubscribe failed.",
   "unsubscribe": "Unsubscribe",
   "escape": "Escape",
-  "loading": "Loading..."
+  "loading": "Loading...",
+  "invalid_asset_id_msg": "Oops! The asset ID you entered does not appear to be valid.",
+  "asset_not_found_msg": "Oops! The asset you are looking for does not exist. Please check the asset id."
 }