-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] Migrate Discharge Reason to Integer Format #1749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashesh3
requested review from
vigneshhari,
rithviknishad,
khavinshankar and
sainak
December 7, 2023 09:34
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
+ Coverage 61.36% 61.38% +0.02%
==========================================
Files 211 211
Lines 11587 11595 +8
Branches 1659 1660 +1
==========================================
+ Hits 7110 7118 +8
Misses 4205 4205
Partials 272 272 ☔ View full report in Codecov by Sentry. |
sainak
requested changes
Dec 7, 2023
care/facility/migrations/0398_alter_patientconsultation_discharge_reason.py
Outdated
Show resolved
Hide resolved
rithviknishad
approved these changes
Dec 7, 2023
care/facility/migrations/0398_alter_patientconsultation_discharge_reason.py
Outdated
Show resolved
Hide resolved
rithviknishad
added
question
Further information is requested
and removed
question
Further information is requested
labels
Dec 7, 2023
Ashesh3
changed the title
Refactor Discharge Reason to Integer Format
[SCHEMA] Migrate Discharge Reason to Integer Format
Dec 11, 2023
Ashesh3
force-pushed
the
discharge-reason-integer
branch
from
December 11, 2023 15:22
738525d
to
cfcdff2
Compare
rithviknishad
approved these changes
Dec 11, 2023
rithviknishad
approved these changes
Dec 11, 2023
As per discussion, this change will be done in 3 steps:
I've converted this PR to just the schema change. |
sainak
approved these changes
Dec 11, 2023
vigneshhari
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend PR: ohcnetwork/care_fe#6807
Proposed Changes
This PR introduces a fundamental change in the representation of the discharge reason field, transitioning from a string-based approach to an enum-based integer format. This modification impacts multiple files including serializers and models, ensuring consistency and improved data handling across the system. Key changes include the introduction of the
DiseaseReasonEnum
class and updates to thedischarge_reason
field in various models to reflect the new enum-based approach. This refactor not only streamlines data processing but also aligns with best practices in data representation, thereby enhancing the system's overall efficiency and maintainability.Associated Issue
discharge_reason
toIntegerField
#1739@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins