Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Migration to Support New Discharge Reason Field #1773

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 12, 2023

Proposed Changes

This PR includes changes for migrating existing data to align with the newly introduced new_discharge_reason field in our database schema. The update ensures backward compatibility and seamless integration of the new field across various modules. The modifications are primarily focused on serializers, viewsets, and tests, ensuring that all functionalities related to patient discharge reasons are updated to use the new field. This change is pivotal for enhancing our data handling capabilities and providing more detailed reasons for patient discharge in our system.

Associated Issue

Phases for the change

  1. Schema Changes
  2. Migrating Data
  3. Moving the temp field back to the original field and deprecate the temp field.

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ef73d93) 61.04% compared to head (870298b) 61.05%.

Files Patch % Lines
care/facility/api/serializers/shifting.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1773   +/-   ##
=======================================
  Coverage   61.04%   61.05%           
=======================================
  Files         208      208           
  Lines       11526    11528    +2     
  Branches     1656     1656           
=======================================
+ Hits         7036     7038    +2     
  Misses       4218     4218           
  Partials      272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ashesh3
Copy link
Member Author

Ashesh3 commented Dec 27, 2023

@rithviknishad @sainak @vigneshhari could you review this PR once?

care/facility/api/serializers/patient.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/serializers/patient_consultation.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/patient.py Outdated Show resolved Hide resolved
@Ashesh3 Ashesh3 requested a review from sainak December 27, 2023 09:18
@Ashesh3
Copy link
Member Author

Ashesh3 commented Jan 3, 2024

@vigneshhari could you review this?

@vigneshhari vigneshhari merged commit c2d0cc9 into master Jan 9, 2024
11 checks passed
@vigneshhari vigneshhari deleted the discharge-reason-integer-data branch January 9, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants