Add list and detail serializer patient external serializer

care/facility/api/serializers/patient_external_test.py

@@ -12,6 +12,7 @@
 
 
 class PatientExternalTestSerializer(serializers.ModelSerializer):
+    # TODO: Remove when #5492 is completed and merged
     ward_object = WardSerializer(source="ward", read_only=True)
     local_body_object = LocalBodySerializer(source="local_body", read_only=True)
     district_object = DistrictSerializer(source="district", read_only=True)
@@ -130,3 +131,114 @@
                 )
 
         return super().update(instance, validated_data)
+
+
+class PatientExternalListSerializer(serializers.ModelSerializer):
+    result_date = serializers.DateField(input_formats=["%Y-%m-%d"], required=False)
+
+    class Meta:
+        model = PatientExternalTest
+        fields = [
+            "id",
+            "name",
+            "age",
+            "age_in",
+            "test_type",
+            "result",
+            "patient_created",
+            "result_date",
+        ]
+
+
+class PatientExternalDetailSerializer(serializers.ModelSerializer):
+    ward_object = WardSerializer(source="ward", read_only=True)
+    local_body_object = LocalBodySerializer(source="local_body", read_only=True)
+    district_object = DistrictSerializer(source="district", read_only=True)
+
+    local_body_type = serializers.CharField(required=False, write_only=True)
+
+    sample_collection_date = serializers.DateField(
+        input_formats=["%Y-%m-%d"], required=False
+    )
+    result_date = serializers.DateField(input_formats=["%Y-%m-%d"], required=False)
+
+    def validate_empty_values(self, data, *args, **kwargs):
+        # if "is_repeat" in data:
+        #     is_repeat = data["is_repeat"]
+        #     if is_repeat.lower() == "yes":
+        #         data["is_repeat"] = True
+        #     else:
+        #         data["is_repeat"] = False
+        district_obj = None
+        if "district" in data:
+            district = data["district"]
+            district_obj = District.objects.filter(name__icontains=district).first()
+            if district_obj:
+                data["district"] = district_obj.id
+            else:
+                raise ValidationError({"district": ["District Does not Exist"]})
+        else:
+            raise ValidationError({"district": ["District Not Present in Data"]})
+
+        if "local_body_type" not in data:
+            raise ValidationError(
+                {"local_body_type": ["local_body_type is not present in data"]}
+            )
+
+        if not data["local_body_type"]:
+            raise ValidationError(
+                {"local_body_type": ["local_body_type cannot be empty"]}
+            )
+
+        if data["local_body_type"].lower() not in REVERSE_LOCAL_BODY_CHOICES:
+            raise ValidationError({"local_body_type": ["Invalid Local Body Type"]})
+
+        local_body_type = REVERSE_LOCAL_BODY_CHOICES[data["local_body_type"].lower()]
+
+        local_body_obj = None
+        if "local_body" in data and district_obj:
+            if not data["local_body"]:
+                raise ValidationError({"local_body": ["Local Body Cannot Be Empty"]})
+            local_body = data["local_body"]
+            local_body_obj = LocalBody.objects.filter(
+                name__icontains=local_body,
+                district=district_obj,
+                body_type=local_body_type,
+            ).first()
+            if local_body_obj:
+                data["local_body"] = local_body_obj.id
+            else:
+                raise ValidationError({"local_body": ["Local Body Does not Exist"]})
+        else:
+            raise ValidationError({"local_body": ["Local Body Not Present in Data"]})
+
+        if "ward" in data and local_body_obj:
+            try:
+                int(data["ward"])
+            except Exception:
+                raise ValidationError({"ward": ["Ward must be an integer value"]})
+            if data["ward"]:
+                ward_obj = Ward.objects.filter(
+                    number=data["ward"], local_body=local_body_obj
+                ).first()
+                if ward_obj:
+                    data["ward"] = ward_obj.id
+                else:
+                    raise ValidationError({"ward": ["Ward Does not Exist"]})
+
+        del data["local_body_type"]
+
+        return super().validate_empty_values(data, *args, **kwargs)
+
+    def create(self, validated_data):
+        if "srf_id" in validated_data:
+            if PatientRegistration.objects.filter(
+                srf_id__iexact=validated_data["srf_id"]
+            ).exists():
+                validated_data["patient_created"] = True
+        return super().create(validated_data)
+
+    class Meta:
+        model = PatientExternalTest
+        fields = "__all__"
+        read_only_fields = ("patient_created",)

care/facility/api/viewsets/patient_external_test.py

@@ -21,7 +21,8 @@
 from rest_framework.viewsets import GenericViewSet
 
 from care.facility.api.serializers.patient_external_test import (
-    PatientExternalTestSerializer,
+    PatientExternalDetailSerializer,
+    PatientExternalListSerializer,
     PatientExternalTestUpdateSerializer,
 )
 from care.facility.models import PatientExternalTest
@@ -71,7 +72,7 @@
     DestroyModelMixin,
     GenericViewSet,
 ):
-    serializer_class = PatientExternalTestSerializer
+    serializer_class = PatientExternalDetailSerializer
     queryset = (
         PatientExternalTest.objects.select_related("ward", "local_body", "district")
         .all()
@@ -100,6 +101,8 @@
         return queryset
 
     def get_serializer_class(self):
+        if self.action == "list":
+            return PatientExternalListSerializer
         if self.action == "update" or self.action == "partial_update":
             return PatientExternalTestUpdateSerializer
         return super().get_serializer_class()
@@ -149,7 +152,7 @@
         invalid = False
         for sample in request.data["sample_tests"]:
             counter += 1
-            serialiser_obj = PatientExternalTestSerializer(data=sample)
+            serialiser_obj = PatientExternalDetailSerializer(data=sample)
             valid = serialiser_obj.is_valid()
             current_error = prettyerrors(serialiser_obj._errors)
             if current_error and (not valid):

care/facility/tests/test_facility_patient_external_test.py

@@ -0,0 +1,124 @@
+from enum import Enum
+
+from rest_framework import status
+from rest_framework.test import APITestCase
+from rest_framework_simplejwt.tokens import RefreshToken
+
+from care.utils.tests.test_utils import TestUtils
+
+
+class ExpectedPatientExternalTestListKeys(Enum):
+    id = "id"
+    name = "name"
+    age = "age"
+    age_in = "age_in"
+    test_type = "test_type"
+    result = "result"
+    patient_created = "patient_created"
+    result_date = "result_date"
+
+
+class ExpectedPatientExternalTestRetrieveKeys(Enum):
+    id = "id"
+    ward_object = "ward_object"
+    local_body_object = "local_body_object"
+    district_object = "district_object"
+    sample_collection_date = "sample_collection_date"
+    result_date = "result_date"
+    external_id = "external_id"
+    created_date = "created_date"
+    modified_date = "modified_date"
+    deleted = "deleted"
+    srf_id = "srf_id"
+    name = "name"
+    age = "age"
+    age_in = "age_in"
+    gender = "gender"
+    address = "address"
+    mobile_number = "mobile_number"
+    is_repeat = "is_repeat"
+    patient_status = "patient_status"
+    source = "source"
+    patient_category = "patient_category"
+    lab_name = "lab_name"
+    test_type = "test_type"
+    sample_type = "sample_type"
+    result = "result"
+    patient_created = "patient_created"
+    ward = "ward"
+    local_body = "local_body"
+    district = "district"
+
+
+class WardKeys(Enum):
+    ID = "id"
+    NAME = "name"
+    NUMBER = "number"
+    LOCAL_BODY = "local_body"
+
+
+class LocalBodyKeys(Enum):
+    ID = "id"
+    NAME = "name"
+    BODY_TYPE = "body_type"
+    LOCALBODY_CODE = "localbody_code"
+    DISTRICT = "district"
+
+
+class DistrictKeys(Enum):
+    ID = "id"
+    NAME = "name"
+    STATE = "state"
+
+
+class PatientExternalTestViewSetTestCase(TestUtils, APITestCase):
+    @classmethod
+    def setUpTestData(cls) -> None:
+        cls.state = cls.create_state()
+        cls.district = cls.create_district(cls.state)
+        cls.super_user = cls.create_super_user(username="su2", district=cls.district)
+        cls.local_body = cls.create_local_body(cls.district)
+        cls.ward = cls.create_ward(cls.local_body)
+        cls.patient_external = cls.create_patient_external_test(
+            district=cls.district, local_body=cls.local_body, ward=cls.ward
+        )
+
+    def setUp(self) -> None:
+        refresh_token = RefreshToken.for_user(self.super_user)
+        self.client.credentials(
+            HTTP_AUTHORIZATION=f"Bearer {refresh_token.access_token}"
+        )
+
+    def test_list_patient_external_test(self):
+        response = self.client.get("/api/v1/external_result/")
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertIsInstance(response.json()["results"], list)
+
+        # Ensure only necessary data is being sent and no extra data
+        expected_keys = [key.value for key in ExpectedPatientExternalTestListKeys]
+        data = response.json()["results"][0]
+        self.assertCountEqual(data.keys(), expected_keys)
+
+    def test_retrieve_patient_external_test(self):
+        response = self.client.get(
+            f"/api/v1/external_result/{self.patient_external.id}/"
+        )
+
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+
+        expected_keys = [key.value for key in ExpectedPatientExternalTestRetrieveKeys]
+
+        data = response.json()
+
+        self.assertCountEqual(data.keys(), expected_keys)
+
+        self.assertCountEqual(
+            data["ward_object"].keys(), [key.value for key in WardKeys]
+        )
+        self.assertCountEqual(
+            data["local_body_object"].keys(), [key.value for key in LocalBodyKeys]
+        )
+        self.assertCountEqual(
+            data["district_object"].keys(), [key.value for key in DistrictKeys]
+        )