Add list and detail serializer patient external serializer #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1539 +/- ##
===========================================
- Coverage 59.11% 59.01% -0.10%
===========================================
Files 207 207
Lines 11264 11325 +61
Branches 1599 1613 +14
===========================================
+ Hits 6659 6684 +25
- Misses 4405 4437 +32
- Partials 200 204 +4 ☔ View full report in Codecov by Sentry. |
sainak
reviewed
Sep 29, 2023
Comment on lines
14
to
18
| class PatientExternalTestSerializer(serializers.ModelSerializer): | ||
| # TODO: Remove when #5492 is completed and merged | ||
| ward_object = WardSerializer(source="ward", read_only=True) | ||
| local_body_object = LocalBodySerializer(source="local_body", read_only=True) | ||
| district_object = DistrictSerializer(source="district", read_only=True) |
| jwcrypto==1.5.0 # https://github.com/latchset/jwcrypto/releases | ||
| pycryptodome==3.16.0 | ||
| pycryptodomex==3.16.0 | ||
| Faker==19.3.0 |
There was a problem hiding this comment.
we have switched to pipenv
run pipenv install --dev faker
sainak
added
the
to-be-closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
patient_external.pyAssociated Issue
patient_external.pyin [C4GT] Create different serializers for list and detail views care_fe#5492Merge Checklist
Only PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins