Simplify rhui #1057

MichalHe · 2023-03-10T18:07:39Z

Simplicity does not precede complexity, but follows it. - Alan Perlis

Currently, leapp uses special leapp-rhui-<provider> packages to access target RHEL content. In order to access the target content, the special package provides leapp with repofile, certificates and keys to access all repositories (BaseOS, AppStream, etc.). The goal of this PR is to simplify how we handle RHUI packages by introducing a preparation step in which the target RHUI client is downloaded, and the repofiles, certs, and keys provided by the target client are used to perform the upgrade. This way, the leapp-rhui-<provider> packages do not need to be synced with provider's clients, reducing required maintenance burden.

If you wish to test this PR it is advised to remove all but the cloud provider's repositories from the repofile provided by the leapp-rhui- packages.

Jira Ref: OAMG-8599

Tested so far on 8>9 aws and 8>9 azure.

github-actions · 2023-03-10T18:07:54Z

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

review please to notify leapp developers of review request
/packit copr-build to submit a public copr build using packit

To launch regression testing public members of oamg organization can leave the following comment:

/rerun to schedule basic regression tests using this pr build and leapp*master* as artifacts
/rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
/rerun-sst to schedule sst tests using this pr build and leapp*master* as artifacts
/rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

Rezney

Thank you very much for the PR. I am ok with the approach. I will try to test it myself at least once to clarify some things but I will defer further testing and review to @PeterMocary and @alexxa for the SAP part. I am sure that when they consider it in a good shape it is ready for merging.

repos/system_upgrade/common/files/upgrade_paths.json

repos/system_upgrade/common/models/rhuiinfo.py

repos/system_upgrade/common/actors/cloud/checkrhui/libraries/checkrhui.py

repos/system_upgrade/common/actors/targetuserspacecreator/libraries/userspacegen.py

repos/system_upgrade/common/libraries/rhui.py

PeterMocary · 2023-07-18T11:17:43Z

/packit copr-build

PeterMocary · 2023-08-09T10:58:11Z

/packit copr-build

PeterMocary

The implementation looks good to me, good job 🚀. Most of the suggestions are minor things and nitpicks, however, there is the maxsplit argument in the split function which is not supported by python2.7 and therefore all 7 to 8 upgrades crash on it.

I manually tested the PR on every cloud provider:

GCP	Base	SAP
7 to 8	✔️*	✔️*
8 to 9	✔️	✔️

* Works after removal of the maxsplit named argument

AWS	Base	SAP
7 to 8	✖️*	✖️*
8 to 9	✔️	✔️

* The upgrade is inhibited on There are no enabled target repositories along with an error. As discussed offline this might be an implementation problem most likely caused by unhandled custom REGION variable in the repository baseurls.

AZURE	Base	SAP-HA	SAP-APPS
7 to 8	✔️*	✔️*	✔️*
8 to 9	✔️	✔️	✔️

* Works after removal of the maxsplit named argument

repos/system_upgrade/common/actors/cloud/checkrhui/libraries/checkrhui.py

repos/system_upgrade/common/actors/targetuserspacecreator/libraries/userspacegen.py

repos/system_upgrade/common/actors/cloud/checkrhui/tests/component_test_checkrhui.py

MichalHe · 2023-08-17T09:06:12Z

/packit build

PeterMocary

I tested the new changes on the GCP (both 7to8 base and 8to9 base) and the upgrade works flawlesly. The testing on AWS revealed problem with upgrading 8to9 (I added the comment to the suspected cause), however, 7to8 base works as intended.

Note that I did not look into the code changes thoroughly just yet.

repos/system_upgrade/common/libraries/rhui.py

alexxa · 2023-09-04T09:26:49Z

to sum up:

azure passes with exception 7.9to8.9 shouldn't exist for SAP as shared earlier, to document like a known issue, not related to this PR
aws fails see a comment above
gcp fails for 7to8 and 8to9 with

File "/usr/lib64/python3.6/shutil.py", line 120, in copyfile
with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/etc/leapp/repos.d/system_upgrade/common/files/rhui/google/leapp-google-sap.repo'

pirat89 · 2023-10-09T08:01:35Z

@PeterMocary go please through all discussions you started and mark them as resolved if not other problem is discovered. also please squash rebase + squash commits so it's prepared for the merge.

pirat89 · 2023-10-09T08:02:49Z

@MichalHe ^ if you want to squash them by yourself, feel free to do it :) we are going to nail it this week

In order to upgrade a RHUI system leapp uses custom `leapp-rhui- X` packages providing leapp with necessary repository definitions as well as certs and keys to access these repositories. The content of the `leapp-rhui-X` packages is therefore almost identical to the RHUI client(s) found on the target systems, implying that leapp's rhui packages must actively mirror any changes to the target client packages. This patch modifies leapp so that leapp uses the `leapp-rhui-X` package only to provide a definion of the repository where a target RHUI client can be found. The current RHUI client and target RHUI client is then (bootstrapped) atomically swapped in the scratch container, allowing the upgrade process to access target content. This change thus minimizes the effort put into maintaining leapp-rhui-X. This patch also does redesigns the "cloud map" to contain declarative descriptions of setups, allowing to produce different the client bootstrap steps if desired (not implemented). The new map also contains information about content channel used on known rhui systems, laying the necessary foundation for better error messages when the user forgets to run leapp with --channel. Finally, the RHUI-handling logic has been mostly isolated into a fully unit-tested actor, whereas the implemented userspacegen modifications have the nature of somehow blindly following the instructions produced by the RHUI actor. Jira: OAMG-8599

PeterMocary

I conducted final testing of the PR:

GCP	Base	SAP
7 to 8	✔️	✔️
8 to 9	✔️	✔️

AZURE	Base	SAP-HA	SAP-APPS
7 to 8	✔️	✔️	✔️
8 to 9	✔️	✔️	✔️

AWS	Base	SAP (e4s)
7 to 8	✔️	✔️
8 to 9	✔️	✔️

We can possibly add the key and certificate files to optional_files in the setups map to ensure backwards compatibility of leapp-rhui-(azure|aws) packages, meaning they don't have to be changed immediately. Although this does not work for GCP, the leapp-rhui-google is in our control so we can change it whenever.

pirat89 · 2023-10-14T08:04:29Z

/packit test

pirat89 · 2023-10-16T13:46:44Z

/packit test

pirat89 · 2023-10-17T16:23:16Z

@PeterMocary can you check why it fails on AWS? The error:

 Curl error (58): Problem with the local SSL certificate for https://rhui.us-east-1.aws.ce.redhat.com/pulp/mirror/content/dist/rhel9/rhui/9.0/x86_64/appstream/debug [could not load PEM client certificate, OpenSSL error error:02001002:system library:fopen:No such file or directory, (no key found, wrong pass phrase, or wrong file format?)]

see our team discussion on slack for more info. not sure whether it's a bug in the PR or test. sync then please with QE. Postponing the merging until all tests pass. (the other 2 failed tests have been caused by infra issue)

MichalHe · 2023-10-17T18:24:01Z

@pirat89 @PeterMocary It might be that the SSL cert is not copied into the scratch container at all.

Now to the more interesting question - why on earth would this PR enable debug repositories?
The "normal" way of functioning of this PR is that the repofile provided within leapp-rhui-X package contains only repositories that is necessary to install the target client, nothing more (debug repos etc.). That way, we do not have to do any runtime selection of the repositories to enable in order to install the target client (no repomapping, etc.) - we just enable what we provide in the repofile. If the test is using the old package with the old repofile, then we are enabling all repositories including debug, but we copy in only repofiles specified in the repomap - SSL cert and key to enable only client repository.

As @PeterMocary written above, backwards compatibility with the old packages can be --- and give the timeframe, should be --- achieved by specifying the SSL key+cert for BaseOS/AppStream repositories as "optional" in the repomap. This way the RHUI code will use these files if they are present, but their absence is ignored.

pirat89 · 2023-10-18T15:06:35Z

@pirat89 @PeterMocary It might be that the SSL cert is not copied into the scratch container at all.

Now to the more interesting question - why on earth would this PR enable debug repositories? The "normal" way of functioning of this PR is that the repofile provided within leapp-rhui-X package contains only repositories that is necessary to install the target client, nothing more (debug repos etc.). That way, we do not have to do any runtime selection of the repositories to enable in order to install the target client (no repomapping, etc.) - we just enable what we provide in the repofile. If the test is using the old package with the old repofile, then we are enabling all repositories including debug, but we copy in only repofiles specified in the repomap - SSL cert and key to enable only client repository.

As @PeterMocary written above, backwards compatibility with the old packages can be --- and give the timeframe, should be --- achieved by specifying the SSL key+cert for BaseOS/AppStream repositories as "optional" in the repomap. This way the RHUI code will use these files if they are present, but their absence is ignored.

Good eyes! Checking the results, all crashed downloads are related to the debug repo, which is to me suspicious how it actually appeared in the test on the first place. But it raises to me another question: why it fails anyway as I'd expect the debug repo needs the very same cert as baseos & appstream, that passed correctly.

pirat89

It's good to go. Despite the potential we are missing something (see the last discussion above), we do not consider this blocker for the merge and I think it's safe enough. The highest porential to catch a real problem is for us right now to merge it, so everyone using/testing the code will add scenarious where we could discover it.

// fanfare 🎺 🎆

## Packaging - Requires xfsprogs and e2fsprogs (oamg#1154) - Bump leapp-repository-dependencies to 10 (oamg#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (oamg#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (oamg#1120) - Drop the invalid `tuv` target channel (oamg#1130) - Fix handling of symlinks under /etc/pki when managing certificates (oamg#1135, oamg#1160, oamg#1166) - Fix semanage import issue (oamg#1164) - Fix the issue of going out of bounds in the isccfg parser (oamg#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (oamg#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (oamg#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (oamg#1134) - Minor updates of generated reports (oamg#1151) - Print nice error msg when device and driver deprecation data is malformed (oamg#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (oamg#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (oamg#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (oamg#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (oamg#1136, oamg#1138) ### Enhancements - Update upgrade paths: (oamg#1146, oamg#1147, oamg#1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (oamg#1143) - Code cleaning: drop redundant and invalid NFS checks (oamg#1127) - Default to NO_RHSM mode when subscription-manager is not found (oamg#1133) - Detect customized configuration of dynamic linker (oamg#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (oamg#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (oamg#1175) - Ignore Leapp related PES events (oamg#1153) - Introduce generic transition of systemd services states during the IPU (oamg#1060, oamg#1174) - Introduce possibility to upgrade with local repositories (oamg#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (oamg#1140) - Report the upgrade customisations and modifications of the upgrade tooling (oamg#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (oamg#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (oamg#1163, oamg#1165, oamg#1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (oamg#1137, oamg#1165, oamg#1172) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (oamg#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (oamg#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (oamg#876)

## Packaging - Requires xfsprogs and e2fsprogs (oamg#1154) - Bump leapp-repository-dependencies to 10 (oamg#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (oamg#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (oamg#1120) - Drop the invalid `tuv` target channel (oamg#1130) - Fix handling of symlinks under /etc/pki when managing certificates (oamg#1135, oamg#1160, oamg#1166) - Fix semanage import issue (oamg#1164) - Fix the issue of going out of bounds in the isccfg parser (oamg#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (oamg#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (oamg#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (oamg#1134) - Minor updates of generated reports (oamg#1151) - Print nice error msg when device and driver deprecation data is malformed (oamg#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (oamg#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (oamg#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (oamg#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (oamg#1136, oamg#1138) ### Enhancements - Update upgrade paths: (oamg#1146, oamg#1147, oamg#1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (oamg#1143) - Code cleaning: drop redundant and invalid NFS checks (oamg#1127) - Default to NO_RHSM mode when subscription-manager is not found (oamg#1133) - Detect customized configuration of dynamic linker (oamg#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (oamg#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (oamg#1175) - Ignore Leapp related PES events (oamg#1153) - Introduce generic transition of systemd services states during the IPU (oamg#1060, oamg#1174) - Introduce possibility to upgrade with local repositories (oamg#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (oamg#1140) - Report the upgrade customisations and modifications of the upgrade tooling (oamg#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (oamg#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (oamg#1163, oamg#1165, oamg#1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (oamg#1137, oamg#1165, oamg#1172) - Unify breakpoints inside the upgrade initramfs for the easier troubleshooting (oamg#1157) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (oamg#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (oamg#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (oamg#876)

## Packaging - Requires xfsprogs and e2fsprogs (#1154) - Bump leapp-repository-dependencies to 10 (#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (#1120) - Drop the invalid `tuv` target channel (#1130) - Fix handling of symlinks under /etc/pki when managing certificates (#1135, #1160, #1166) - Fix semanage import issue (#1164) - Fix the issue of going out of bounds in the isccfg parser (#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (#1134) - Minor updates of generated reports (#1151) - Print nice error msg when device and driver deprecation data is malformed (#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (#1136, #1138) ### Enhancements - Update upgrade paths: (#1146, #1147, #1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (#1143) - Code cleaning: drop redundant and invalid NFS checks (#1127) - Default to NO_RHSM mode when subscription-manager is not found (#1133) - Detect customized configuration of dynamic linker (#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (#1175) - Ignore Leapp related PES events (#1153) - Introduce generic transition of systemd services states during the IPU (#1060, #1174) - Introduce possibility to upgrade with local repositories (#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (#1140) - Report the upgrade customisations and modifications of the upgrade tooling (#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (#1163, #1165, #1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (#1137, #1165, #1172) - Unify breakpoints inside the upgrade initramfs for the easier troubleshooting (#1157) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (#876)

## Packaging - Requires xfsprogs and e2fsprogs (oamg#1154) - Bump leapp-repository-dependencies to 10 (oamg#1154) ## Upgrade handling ### Fixes - Detect changes in openssl default configuration file and restore it to the default to the target default during the upgrade to reduce risk of potential issues (oamg#1131) - Do not try to download data files anymore when missing as the service is obsoleted since the data is part of installed packages (oamg#1120) - Drop the invalid `tuv` target channel (oamg#1130) - Fix handling of symlinks under /etc/pki when managing certificates (oamg#1135, oamg#1160, oamg#1166) - Fix semanage import issue (oamg#1164) - Fix the issue of going out of bounds in the isccfg parser (oamg#1124) - Fix traceback when saving the rhsm facts results and the /etc/rhsm/facts directory doesn’t exist yet (oamg#1132) - Handle the upgrade better when a proxy is configured in YUM/DNF configutations (oamg#1143) - Load all rpm repository substitutions that dnf knows about, not just releasever since repofiles may use the other substitutions too (oamg#1134) - Minor updates of generated reports (oamg#1151) - Print nice error msg when device and driver deprecation data is malformed (oamg#1168) - Report information about required manual steps after the upgrade when openssl-ibmca is installed (oamg#1131) - Update error messages and reports when installed upgrade data files are malformed or missing (oamg#1120) - [IPU 7 -> 8] Fix the upgrade of the RH Satellite server when tomcat is installed (oamg#1150) - [IPU 8 -> 9] Fix the upgrade from RHEL 8.9+ when the release is locked by subscription-manager (oamg#1136, oamg#1138) ### Enhancements - Update upgrade paths: (oamg#1146, oamg#1147, oamg#1175) - RHEL 7.9 -> 8.10, 8.8 (default: 8.10) - RHEL with SAPAHA 7.9 -> 8.10, 8.8 (default: 8.8) - RHEL w/o SAP HANA 8.8 -> 9.2 - RHEL w/o SAP HANA 8.10 -> 9.4 - Added possibility to define DNF configuration for the target system (oamg#1143) - Code cleaning: drop redundant and invalid NFS checks (oamg#1127) - Default to NO_RHSM mode when subscription-manager is not found (oamg#1133) - Detect customized configuration of dynamic linker (oamg#1118) - Detect possible unexpected RPM GPG keys has been installed during RPM transaction (oamg#1101) - Drop obsoleted upgrade paths that relates to releases: 8.6, 8.9, 9.0, 9.3 (oamg#1175) - Ignore Leapp related PES events (oamg#1153) - Introduce generic transition of systemd services states during the IPU (oamg#1060, oamg#1174) - Introduce possibility to upgrade with local repositories (oamg#1099) - Introduced some changes getting us closer to possibility of IPU for Centos (Stream) systems (oamg#1140) - Report the upgrade customisations and modifications of the upgrade tooling (oamg#1148) - Simplify handling of upgrades on systems using RHUI, reducing the maintenance burden for cloud providers (oamg#1057) - Update the leapp upgrade data files - bump data stream to "3.0" (oamg#1163, oamg#1165, oamg#1170) - [IPU 8 -> 9] Enable upgrades RHEL 8 -> 9 using RHUI on Alibaba cloud (oamg#1137, oamg#1165, oamg#1172) - Unify breakpoints inside the upgrade initramfs for the easier troubleshooting (oamg#1157) ## Additional changes interesting for devels - Introduced new functions returning a list of packages related to upgrade - see the rpms library (oamg#1156) - Make detection of installed signed packages distribution agnostic - covers RHEL & CentOS (oamg#876) - Model InstalledRedHatSignedRPM is deprecated, replaced by DistributionSignedRPM (oamg#876) (cherry picked from commit 6421225)

pirat89 added this to the 8.9/9.3 milestone Mar 13, 2023

pirat89 mentioned this pull request Mar 13, 2023

checkrhui: Produce TargetUserSpacePreupgradeTasks + refactoring #699

Closed

MichalHe force-pushed the simplify_rhui branch from 1ebbc77 to 5b408ee Compare April 1, 2023 09:06

MichalHe force-pushed the simplify_rhui branch from f17e0a0 to 15c465f Compare April 9, 2023 19:06

MichalHe force-pushed the simplify_rhui branch 7 times, most recently from 7d29c4d to 7ad0c6d Compare April 24, 2023 10:46

MichalHe marked this pull request as ready for review June 15, 2023 11:41

MichalHe force-pushed the simplify_rhui branch from b5003e8 to 331e47a Compare June 15, 2023 11:47

Rezney reviewed Jun 20, 2023

View reviewed changes

PeterMocary reviewed Jun 26, 2023

View reviewed changes

repos/system_upgrade/common/libraries/rhui.py Outdated Show resolved Hide resolved

MichalHe force-pushed the simplify_rhui branch from 59387c8 to b9deee8 Compare July 31, 2023 09:42

PeterMocary requested changes Aug 16, 2023

View reviewed changes

MichalHe force-pushed the simplify_rhui branch from 7120c8f to e5490b2 Compare August 21, 2023 10:34

PeterMocary self-assigned this Aug 21, 2023

pirat89 modified the milestones: 8.9/9.3, 8.10/9.4 Aug 21, 2023

MichalHe force-pushed the simplify_rhui branch 5 times, most recently from 25b2e2f to 3141e6e Compare August 21, 2023 14:06

MichalHe force-pushed the simplify_rhui branch from b9d16ce to 4fb9981 Compare August 24, 2023 11:16

PeterMocary requested changes Aug 24, 2023

View reviewed changes

repos/system_upgrade/common/libraries/rhui.py Outdated Show resolved Hide resolved

PeterMocary reviewed Aug 28, 2023

View reviewed changes

repos/system_upgrade/common/libraries/rhui.py Outdated Show resolved Hide resolved

MichalHe force-pushed the simplify_rhui branch from 4fb9981 to b942d87 Compare August 29, 2023 09:34

MichalHe force-pushed the simplify_rhui branch from 00d41aa to 87c1c53 Compare October 9, 2023 20:54

pirat89 mentioned this pull request Oct 10, 2023

make pylint happy #1129

Merged

PeterMocary force-pushed the simplify_rhui branch from 87c1c53 to c3824c0 Compare October 12, 2023 17:02

PeterMocary previously approved these changes Oct 12, 2023

View reviewed changes

add backward compatibility for leapp-rhui-(aws|azure) packages

89d585f

PeterMocary dismissed their stale review via 89d585f October 18, 2023 13:34

pirat89 approved these changes Nov 10, 2023

View reviewed changes

pirat89 merged commit 594cdb9 into oamg:master Nov 10, 2023
17 of 29 checks passed

pirat89 added changelog-checked The merger/reviewer checked the changelog draft document and updated it when relevant report Any reports have been added / removed / changed in the PR labels Nov 10, 2023

pirat89 mentioned this pull request Feb 13, 2024

Release 0.20.0 #1177

Merged

yuravk mentioned this pull request Aug 9, 2024

Update to version 0.20.0 AlmaLinux/leapp-repository#119

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify rhui #1057

Simplify rhui #1057

MichalHe commented Mar 10, 2023 •

edited

Loading

github-actions bot commented Mar 10, 2023

Rezney left a comment

PeterMocary commented Jul 18, 2023

PeterMocary commented Aug 9, 2023

PeterMocary left a comment •

edited

Loading

MichalHe commented Aug 17, 2023

PeterMocary left a comment

alexxa commented Sep 4, 2023

pirat89 commented Oct 9, 2023

pirat89 commented Oct 9, 2023

PeterMocary left a comment •

edited

Loading

pirat89 commented Oct 14, 2023

pirat89 commented Oct 16, 2023

pirat89 commented Oct 17, 2023 •

edited

Loading

MichalHe commented Oct 17, 2023

pirat89 commented Oct 18, 2023

pirat89 left a comment

Simplify rhui #1057

Simplify rhui #1057

Conversation

MichalHe commented Mar 10, 2023 • edited Loading

github-actions bot commented Mar 10, 2023

Thank you for contributing to the Leapp project!

Rezney left a comment

Choose a reason for hiding this comment

PeterMocary commented Jul 18, 2023

PeterMocary commented Aug 9, 2023

PeterMocary left a comment • edited Loading

Choose a reason for hiding this comment

MichalHe commented Aug 17, 2023

PeterMocary left a comment

Choose a reason for hiding this comment

alexxa commented Sep 4, 2023

pirat89 commented Oct 9, 2023

pirat89 commented Oct 9, 2023

PeterMocary left a comment • edited Loading

Choose a reason for hiding this comment

pirat89 commented Oct 14, 2023

pirat89 commented Oct 16, 2023

pirat89 commented Oct 17, 2023 • edited Loading

MichalHe commented Oct 17, 2023

pirat89 commented Oct 18, 2023

pirat89 left a comment

Choose a reason for hiding this comment

MichalHe commented Mar 10, 2023 •

edited

Loading

PeterMocary left a comment •

edited

Loading

PeterMocary left a comment •

edited

Loading

pirat89 commented Oct 17, 2023 •

edited

Loading