checkrhui: Produce TargetUserSpacePreupgradeTasks + refactoring #699
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
The RequiredTargetUserspacePackages model has been deprecated in favor of the TargetUserSpacePreupgradeTasks model. Keeping the original functionality + produce the new msg as well. Additionally the actor is a little bit refactored.
pirat89
force-pushed
the
checkrhui-update
branch
from
a473490 to
07a9c5c
Compare
| self.produce(RHUIInfo(provider=provider)) | ||
| self.produce(RequiredTargetUserspacePackages(packages=[info['el8_pkg']])) | ||
| self.produce(RpmTransactionTasks( | ||
| to_install=[info['el8_pkg']], |
There was a problem hiding this comment.
Since this is in common, do we want to keep el8_pkg and el7_pkg? Renaming those to old_pkg and new_pkg would make much more sense in common context.
There was a problem hiding this comment.
@shaded-enmity Good point. We could define the new/old variables in the begining of the begining and than just use these variables everywhere to work with the map in the share library.
MichalHe
dismissed
their stale review
Valid concerns have been requested by other reviewers, therefore, postponing the approval.
|
/packit build |
|
No config file for packit (e.g. For more info, please check out the documentation: https://packit.dev/docs/packit-service or contact us - Packit team |
|
@MichalHe you can ignore this one for now. we know it's need to be rebased but currently this is postponed for the month after the release. |
|
@fernflower not sure whether the RHUI actors have been already refactored. this should really happen still if they are not using new up-to-date standards instead of deprecated functionality. let's keep it for the next release, where I would like to propose to drop some deprecated functionalities to clean the code. |
|
Closing in favor of PR #1057 |
The RequiredTargetUserspacePackages model has been deprecated
in favor of the TargetUserSpacePreupgradeTasks model. Keeping
the original functionality + produce the new msg as well.
Additionally the actor is a little bit refactored.