Add client metadata + API #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
commented
Sep 13, 2023
| @@ -280,3 +280,273 @@ type OpenID4VCIFields struct { | |||
| PreAuthorizedGrantAnonymousAccessSupported bool `json:"pre-authorized_grant_anonymous_access_supported"` | |||
| //OPTIONAL. A JSON Boolean indicating whether the issuer accepts a Token Request with a Pre-Authorized Code but without a client id. The default is false. | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this is a scratch pad with comments useful during development
woutslakhorst
requested changes
Sep 14, 2023
auth/api/iam/metadata.go
Outdated
| softwareID, softwareVersion, _ := strings.Cut(core.UserAgent(), "/") | ||
| return OAuthClientMetadata{ | ||
| //RedirectURIs: nil, | ||
| TokenEndpointAuthMethod: "client_secret_basic", // TODO: this is the default value, what do we support |
There was a problem hiding this comment.
I'm guessing it would become vp_token-bearer?
There was a problem hiding this comment.
that would require defining a client assertion type using the vp_token next to the grant_type similar to RFC7523 describing a
urn:ietf:params:oauth:client-assertion-type:jwt-bearer and
urn:ietf:params:oauth:grant-type:jwt-bearer
| TokenEndpointAuthMethod: "client_secret_basic", // TODO: this is the default value, what do we support | ||
| GrantTypes: grantTypesSupported, | ||
| ResponseTypes: responseTypesSupported, | ||
| //Scope: "", |
There was a problem hiding this comment.
I left them as comments to see what fields still need to added, but I will remove them.
There was a problem hiding this comment.
Left the remaining values commented. They either need to be set by the time these flows are implmented or removed.
woutslakhorst
approved these changes
Sep 18, 2023
gerardsn
force-pushed
the
oauth/client-metadata
branch
from
b0b2023 to
0b84dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fill out as much as possible, but there are still a bunch of unknowns (tagged with TODOs). I've skipped all the fields related to openid connect / id_token for now. We can add these as needed.