Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed OAS to reflect path component is the ID part of a DID #2493

Merged
merged 3 commits into from
Sep 20, 2023
Merged

changed OAS to reflect path component is the ID part of a DID #2493

merged 3 commits into from
Sep 20, 2023

Conversation

woutslakhorst
Copy link
Member

The APIs under iam/{id} no longer expect a DID as param but only the ID part.

@woutslakhorst woutslakhorst marked this pull request as ready for review September 15, 2023 14:00
gerardsn
gerardsn reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added api.go#validateAsNutsFingerprint in #2488 to do just this. I did not apply it to the other APIs in that PR yet for the sake of scope creep. Which one should we keep?

@woutslakhorst woutslakhorst force-pushed the fix/public_web_did_urls branch from 1341021 to 12aa99d Compare September 19, 2023 08:38
gerardsn
gerardsn requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content of GetOAuthAuthorizationServerMetadata and GetOAuthClientMetadata should match 1:1

auth/api/iam/api.go Outdated Show resolved Hide resolved
@woutslakhorst woutslakhorst force-pushed the fix/public_web_did_urls branch from fe54d9a to fd90535 Compare September 19, 2023 14:01
@woutslakhorst woutslakhorst merged commit 974e7aa into master Sep 20, 2023
6 checks passed
@woutslakhorst woutslakhorst deleted the fix/public_web_did_urls branch September 20, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardsn gerardsn gerardsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woutslakhorst @gerardsn