Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): rspack should allow ES config module imports #29095

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(bundling): rspack should allow ES config module imports #29095

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0f17c2
fix(bundling): rspack should allow ES config module imports
meeroslav Nov 27, 2024
4d571e8
fix(bundling): add awaits
meeroslav Nov 27, 2024
6da294e
Merge branch 'master' into fix/rspack-custom-config
meeroslav Dec 2, 2024
5327667
Merge branch 'master' into fix/rspack-custom-config
meeroslav Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/rspack/src/utils/resolve-user-defined-rspack-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function resolveUserDefinedRspackConfig(
// Don't transpile non-TS files. This prevents workspaces libs from being registered via tsconfig-paths.
// There's an issue here with Nx workspace where loading plugins from source (via tsconfig-paths) can lead to errors.
if (!/\.(ts|mts|cts)$/.test(path)) {
return require(path);
return import(path);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the function to return a Promise in some circumstances.

That's going to impact how this function is used in config.ts and plugin.ts.

}

const cleanupTranspiler = registerTsProject(tsConfig);
Expand Down