-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundling): rspack should allow ES config module imports #29095
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5327667. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
@@ -18,7 +18,7 @@ export function resolveUserDefinedRspackConfig( | |||
// Don't transpile non-TS files. This prevents workspaces libs from being registered via tsconfig-paths. | |||
// There's an issue here with Nx workspace where loading plugins from source (via tsconfig-paths) can lead to errors. | |||
if (!/\.(ts|mts|cts)$/.test(path)) { | |||
return require(path); | |||
return import(path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the function to return a Promise in some circumstances.
That's going to impact how this function is used in config.ts
and plugin.ts
.
Reproduction repo: https://github.com/olaf-cichocki/sample
Current Behavior
When using mjs config file we end up with following error:
Expected Behavior
Using EU module config files is supported
Related Issue(s)
Fixes #
Thank you @olaf-cichocki for reporting the issue.