Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nv 2906 remove the is topic notification enabled feature flag #5493

Merged
merged 11 commits into from
May 7, 2024
Merged

Nv 2906 remove the is topic notification enabled feature flag #5493

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bb2da97
refactor: Remove unused feature flag
denis-kralj-novu May 3, 2024
f572173
refactor: Remove unused feature flag
denis-kralj-novu May 3, 2024
293d41c
refactor: Remove unused feature flag
denis-kralj-novu May 3, 2024
d03423e
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
24bf4bd
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
456912d
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
1dbf6aa
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
b0c9be8
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
e39da35
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
300fa2c
refactor: Remove unused feature flag
denis-kralj-novu May 6, 2024
f294347
Merge branch 'next' into nv-2906-remove-the-is_topic_notification_ena…
denis-kralj-novu May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@
"websockets",
"whatsapp",
"whatsappbusiness",
"parens"
"parens",
],
"flagWords": [],
"patterns": [
Expand Down Expand Up @@ -731,5 +731,6 @@
".env.local",
".env.production",
".env.test",
".example.env",
]
}
1 change: 0 additions & 1 deletion apps/api/src/.env.development
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ LOGGING_LEVEL=info
VERCEL_REDIRECT_URI=https://dev.web.novu.co/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true
FF_IS_DISTRIBUTED_LOCK_LOGGING_ENABLED=false
IS_TRANSLATION_MANAGER_ENABLED=false

Expand Down
1 change: 0 additions & 1 deletion apps/api/src/.env.production
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ LOGGING_LEVEL=info
VERCEL_REDIRECT_URI=https://web.novu.co/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true
FF_IS_DISTRIBUTED_LOCK_LOGGING_ENABLED=false
IS_TRANSLATION_MANAGER_ENABLED=false

Expand Down
2 changes: 0 additions & 2 deletions apps/api/src/.env.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ VERCEL_CLIENT_SECRET=
VERCEL_REDIRECT_URI=http://127.0.0.1:4200/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true

STORE_NOTIFICATION_CONTENT=true

MAX_NOVU_INTEGRATION_MAIL_REQUESTS=300
Expand Down
1 change: 0 additions & 1 deletion apps/api/src/.example.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ VERCEL_CLIENT_SECRET=
VERCEL_REDIRECT_URI=http://127.0.0.1:4200/auth/login
VERCEL_BASE_URL=https://api.vercel.com

IS_TOPIC_NOTIFICATION_ENABLED=true
IS_TRANSLATION_MANAGER_ENABLED=false

STORE_NOTIFICATION_CONTENT=true
Expand Down
Loading
Loading