Nv 2906 remove the is topic notification enabled feature flag #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
denis-kralj-novu
force-pushed
the
nv-2906-remove-the-is_topic_notification_enabled-feature-flag
branch
from
97236a7 to
7bddb39
Compare
Remove unused injections Move single use helper to class using it Remove unused imports Tidy up imports
Remove map-trigger-recipients use case Remove associated e2e tests Remove setting of feature flag in e2e tests Remove feature flag from env validator Remove feature flag from env configurations Remove feature flag from list of feature flags Remove feature flag read and false handling from trigger-multicast use case
Add (ugly) solution to verify matching of enum name and value
Remove unused export
denis-kralj-novu
force-pushed
the
nv-2906-remove-the-is_topic_notification_enabled-feature-flag
branch
from
7bddb39 to
d03423e
Compare
ignore example env config for spell check
Remove unused import
Add alternative checking of flag name match check
denis-kralj-novu
commented
May 6, 2024
denis-kralj-novu
commented
May 6, 2024
Remove non typescript check option Name variable underscore to imply non-use Refactor tests for flag test specs
denis-kralj-novu
force-pushed
the
nv-2906-remove-the-is_topic_notification_enabled-feature-flag
branch
from
8cd7b84 to
b0c9be8
Compare
ainouzgali
reviewed
May 6, 2024
There was a problem hiding this comment.
@denis-kralj-novu looks great💃🏼
Just note my comment about removing the launch darkly env variable in the test files
...s/application-generic/src/usecases/map-trigger-recipients/map-trigger-recipients.use-case.ts
Outdated
Show resolved
Hide resolved
Remove Remove flag setting as per MR suggestion
Remove additional occurrences of feature flag that isn't required
…bled-feature-flag
denis-kralj-novu
deleted the
nv-2906-remove-the-is_topic_notification_enabled-feature-flag
branch
antonjoel82
pushed a commit
that referenced
this pull request
May 9, 2024
Remove unused injections Move single use helper to class using it Remove unused imports Tidy up imports Remove map-trigger-recipients use case Remove associated e2e tests Remove setting of feature flag in e2e tests Remove feature flag from env validator Remove feature flag from env configurations Remove feature flag from list of feature flags Remove feature flag read and false handling from trigger-multicast use case Add (ugly) solution to verify matching of enum name and value Ignore example env config for spell check Ensure feature flag enum keys match values Name variable underscore to imply non-use Refactor tests for flag test specs Remove additional occurrences of feature flag that isn't required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
A feature flag that is always set to true has been removed, along with all associated 'false' code paths. Additionally, dead code was also removed and used helpers moved to more appropriate places
Special notes for your reviewer
I've placed 2 options in this MR and we should agree on what option we want to use. I'm leaning more towards Option 1 as it complains right away, not only when tests are run. Option 2 also seems a bit ugly, but that is more personal preference.