Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add google analytics script tag #5437

Merged
merged 4 commits into from
Apr 26, 2024
+31 −4
Merged

feat: add google analytics script tag #5437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a15d24c
feat: add google analytics script tag
jainpawan21 Apr 19, 2024
87791ef
fix: add conditions and environment variables
jainpawan21 Apr 22, 2024
d892303
fix: add react app gtm id in reusable web deploy yml
jainpawan21 Apr 24, 2024
6c8fc29
Merge branch 'next' into feature/add-gtag
jainpawan21 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable-web-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
echo REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID=${{ secrets.LAUNCH_DARKLY_CLIENT_SIDE_ID }} >> .env
echo REACT_APP_HUBSPOT_EMBED=${{ inputs.react_app_hubspot_embed }} >> .env
echo REACT_APP_STRIPE_CLIENT_KEY=${{ secrets.STRIPE_CLIENT_KEY }} >> .env

echo REACT_APP_NOVU_GTM_ID=${{ secrets.REACT_APP_NOVU_GTM_ID }} >> .env
- name: Envsetup
working-directory: apps/web
run: npm run envsetup
Expand Down
1 change: 1 addition & 0 deletions apps/web/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ REACT_APP_LAUNCH_DARKLY_CLIENT_SIDE_ID=
IS_TEMPLATE_STORE_ENABLED=
IS_MULTI_PROVIDER_CONFIGURATION_ENABLED=
IS_MULTI_TENANCY_ENABLED=
REACT_APP_NOVU_GTM_ID=
32 changes: 29 additions & 3 deletions apps/web/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,22 @@
<!DOCTYPE html>
<html lang="en">
<head>
<!-- Google Tag Manager -->
<% if ( process.env.REACT_APP_NOVU_GTM_ID ) { %>
<script>
(function (w, d, s, l, i) {
w[l] = w[l] || [];
w[l].push({ 'gtm.start': new Date().getTime(), event: 'gtm.js' });
var f = d.getElementsByTagName(s)[0],
j = d.createElement(s),
dl = l != 'dataLayer' ? '&l=' + l : '';
j.async = true;
j.src = 'https://www.googletagmanager.com/gtm.js?id=' + i + dl;
f.parentNode.insertBefore(j, f);
})(window, document, 'script', 'dataLayer', '%REACT_APP_NOVU_GTM_ID%');
</script>
<% } %>
<!-- End Google Tag Manager -->
<meta charset="utf-8" />
<link rel="icon" href="%PUBLIC_URL%/favicon-gradient.png" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
Expand Down Expand Up @@ -28,6 +44,18 @@
<script src="%PUBLIC_URL%/env-config.js"></script>
</head>
<body>
<!-- Google Tag Manager (noscript) -->
<% if ( process.env.REACT_APP_NOVU_GTM_ID ) { %>
<noscript>
<iframe
src="https://www.googletagmanager.com/ns.html?id=%REACT_APP_NOVU_GTM_ID%"
height="0"
width="0"
style="display: none; visibility: hidden"
></iframe>
</noscript>
<% } %>
<!-- End Google Tag Manager (noscript) -->
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
<% if ( process.env.REACT_APP_DOCKER_HOSTED_ENV === 'false' ) { %>
Expand All @@ -37,9 +65,7 @@
async="async"
type="text/javascript"
></script>
<% } %>

<% if ( process.env.REACT_APP_HUBSPOT_EMBED ) { %>
<% } %> <% if ( process.env.REACT_APP_HUBSPOT_EMBED ) { %>
<!-- Start of HubSpot Embed Code -->
<script type="text/javascript" id="hs-script-loader" async defer src="//js.hs-scripts.com/<%= process.env.REACT_APP_HUBSPOT_EMBED %>.js"></script>
<!-- End of HubSpot Embed Code -->
Expand Down
Loading