feat: add google analytics script tag #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jainpawan21
requested review from
a team,
davidsoderberg and
BiswaViraj
and removed request for
a team
LetItRock
reviewed
Apr 19, 2024
apps/web/public/index.html
Outdated
| j.async = true; | ||
| j.src = 'https://www.googletagmanager.com/gtm.js?id=' + i + dl; | ||
| f.parentNode.insertBefore(j, f); | ||
| })(window, document, 'script', 'dataLayer', 'GTM-KXMC4XP2'); |
There was a problem hiding this comment.
GTM identifier should be taken from the env variables passed from the pipelines. It will be different per environment (dev/staging/prod).
Also are we sure that we want to use the same identifier for both EU and US regions?
There was a problem hiding this comment.
As per Justin's message in slack, it will be the same for all environments.
- Added conditions and support of environment variables. I can remove these conditions and variables if you think it is not needed anymore.
scopsy
reviewed
Apr 24, 2024
jainpawan21
requested review from
scopsy and
Cliftonz
and removed request for
a team
LetItRock
approved these changes
Apr 26, 2024
AliaksandrRyzhou
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Ref:- INF-344
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer