Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Invite-members icon is changed in header-nav #4695

Merged
merged 18 commits into from
Nov 10, 2023

Conversation

maverox
Copy link
Contributor

@maverox maverox commented Oct 29, 2023

What change does this PR introduce?

changed the invite-members icon to a more appropriate icon.(from the figma designed enclosed in issue #4601 )

Why was this change needed?

Closes #4601

Code Changes

  • created a new component called InviteMembers.tsx
  • and changed all the <Mail /> in HeaderNav.tsx with <InviteMembers /> component

Screenshot

Screenshot 2023-10-24 183928
Screenshot 2023-10-24 183938

Other information (Screenshots)

@p-fernandez
Copy link
Contributor

@maverox you need to do pnpm install again in your local and commit the pnpm-lock.yml file as it is what is preventing for installing everything properly. There is a mismatch in that file that causes right now the tests to not pass.
The feature itself, now that you are putting it into the right place (/libs/design-system) after the changes the core team has done, should work ok.

@maverox
Copy link
Contributor Author

maverox commented Nov 5, 2023

@maverox you need to do pnpm install again in your local and commit the pnpm-lock.yml file as it is what is preventing for installing everything properly. There is a mismatch in that file that causes right now the tests to not pass. The feature itself, now that you are putting it into the right place (/libs/design-system) after the changes the core team has done, should work ok.

I tried to resolve conflict multiple times but for some reason it doesn't work.
I tried pulling the latest upstream/next (not origin/next (forked remote) ) and then resolved the conflict by only accepting incoming and then doing pnpm install and build and then tested the web component, and it was working fine.

@rifont rifont changed the title Fix: Invite-members icon is changed in header-nav fix(web): Invite-members icon is changed in header-nav Nov 10, 2023
Copy link
Collaborator

@rifont rifont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution @maverox !

@rifont rifont merged commit 2ff7977 into novuhq:next Nov 10, 2023
16 of 17 checks passed
@maverox
Copy link
Contributor Author

maverox commented Nov 14, 2023

Looks great, thanks for your contribution @maverox !

thanks a lot for fixing the pnpmlock issue, but can you please tell what was the issue and how you fixed it by deleting that specific section of file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NV-3048] Update invite members icon when a user click on the avatar.
3 participants