Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NV-3048] Update invite members icon when a user click on the avatar. #4601

Closed
maverox opened this issue Oct 20, 2023 · 9 comments · Fixed by #4695
Closed

[NV-3048] Update invite members icon when a user click on the avatar. #4601

maverox opened this issue Oct 20, 2023 · 9 comments · Fixed by #4695

Comments

@maverox
Copy link
Contributor

maverox commented Oct 20, 2023

📜 Description
We can have a different icon for the invite members button

👟 Reproduction steps
Click on the profile icon at the top right
Small Icon with >invite Members button
📸ScreenShot
Screenshot 2023-10-20 194629

👍 Expected behavior
Please implement the changes according to this Figma designs

👎 Actual Behavior with Screenshots
Novu version
0.18.0

npm version
No response

node version
No response

📃 Provide any additional context for the Bug.
👀 Have you spent some time to check if this bug has been raised before?
I checked and didn't find a similar issue
🏢 Have you read the Contributing Guidelines?
I have read the Contributing Guidelines
Are you willing to submit PR?
Yes I am willing to submit a PR!

NV-3048

@Priyanshuthapliyal2005
Copy link

can i work on this issue

@maverox
Copy link
Contributor Author

maverox commented Oct 21, 2023

can i work on this issue

hey, I am also waiting to be assigned on this, that's why i raised this issue
the thing is we have to wait for the maintainers to check on this issue and then assign it.

@p-fernandez p-fernandez changed the title Update invite members icon when a user click on the avatar. [NV-3048] Update invite members icon when a user click on the avatar. Oct 21, 2023
@p-fernandez p-fernandez closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2023
@p-fernandez
Copy link
Contributor

@maverox closing this as it is a duplicate of this one: #4111

@p-fernandez p-fernandez reopened this Oct 21, 2023
@p-fernandez
Copy link
Contributor

Reopening again as I thought it was tackled in the other PR. Assigning to you @maverox

@Sukomal07
Copy link

@p-fernandez please review my PR

@maverox
Copy link
Contributor Author

maverox commented Oct 23, 2023

@p-fernandez can you please review my PR #4622

@p-fernandez
Copy link
Contributor

@Sukomal07 thank you for the effort because you did a good PR. Unfortunately the issue was assigned to @maverox so I had to close your PR in favour of his.
Please next time, before starting to work in any issue ask to get is assigned to avoid working in things other contributor is working. We have multiple issues and opportunities to collaborate with so take a look on any that is unassigned that might catch your interest. Thank you.

@Sukomal07
Copy link

@p-fernandez Thank you, when i start work on this issue noone is assigned. Bad luck for me 😄

@maverox
Copy link
Contributor Author

maverox commented Oct 29, 2023

@p-fernandez please review pr #4695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment