Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Novu to Node 18 LTS #4014

Merged
merged 21 commits into from
Oct 17, 2023
Merged

Conversation

raikasdev
Copy link
Contributor

What change does this PR introduce?

This PR updates the project to use Node 18 everywhere.

Why was this change needed?

Closes #1959

The only currently supported version, Node 16 LTS has it's end-of-life on September 11th 2023, about three weeks away now.

Other information (Screenshots)

Probably should be discussed if the project should add support up to version 20, which is currently active and will become LTS soon. I will happily make any changes necessary.

All docker container image tag changes have been checked to exist.

Currently this PR sets the node version requirement to >=18.17.1 <19, meaning it accepts the current latest LTS patch or a later patch in 18.x, but not versions with a older or a newer major (19, 20).

@Cliftonz
Copy link
Contributor

Cliftonz commented Aug 25, 2023

@raikasdev Thanks for this PR, I can not speak to the failing tests but there is some spell checks that need to be updated.

@raikasdev
Copy link
Contributor Author

Oh, some containers might be missing make or something. Will have to investigate on monday when I'm back at home, thanks for pointing out!

@raikasdev
Copy link
Contributor Author

I could not find anything that should have broken those tests. In the E2E tests the servers are starting according to the logs, and in the build Docker API seems to be due to PRs from forks using dockerx instead of Depot used for non-forks (resulting in it succeeding for maintainers and seeming like it's working 🤷)

@Cliftonz
Copy link
Contributor

@raikasdev Thanks for responding. The one thing that is failing but can easily be fixed is the Spell Check CI. All you need to do is add the names to the .cspell file.

@Cliftonz
Copy link
Contributor

@djabarovgeorge @LetItRock Would you be able to help with the failing pipelines?

@raikasdev
Copy link
Contributor Author

All failing pipelines seem to be due to missing environmental values (new relic on e2e_web) and not using Depot for the docker API images (due to PR coming from outside repo).

@jainpawan21
Copy link
Member

Tagging @scopsy and @p-fernandez for more visibility of this PR.

@scopsy scopsy changed the base branch from next to node-upgrade September 29, 2023 09:40
@github-actions github-actions bot added stale Pull Request that needs to be reviewed and removed stale Pull Request that needs to be reviewed labels Oct 13, 2023
@scopsy
Copy link
Contributor

scopsy commented Oct 17, 2023

reopening this in another PR to run properly the tests

@scopsy scopsy merged commit f2bd79a into novuhq:node-upgrade Oct 17, 2023
21 of 24 checks passed
@scopsy scopsy mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Update to current active version of Node (18)
4 participants