-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Novu to Node 18 LTS #4014
Conversation
26c2931
to
4c1e121
Compare
@raikasdev Thanks for this PR, I can not speak to the failing tests but there is some spell checks that need to be updated. |
Oh, some containers might be missing make or something. Will have to investigate on monday when I'm back at home, thanks for pointing out! |
I could not find anything that should have broken those tests. In the E2E tests the servers are starting according to the logs, and in the build Docker API seems to be due to PRs from forks using dockerx instead of Depot used for non-forks (resulting in it succeeding for maintainers and seeming like it's working 🤷) |
@raikasdev Thanks for responding. The one thing that is failing but can easily be fixed is the Spell Check CI. All you need to do is add the names to the .cspell file. |
@djabarovgeorge @LetItRock Would you be able to help with the failing pipelines? |
…u into update-to-newer-node
All failing pipelines seem to be due to missing environmental values (new relic on e2e_web) and not using Depot for the docker API images (due to PR coming from outside repo). |
Tagging @scopsy and @p-fernandez for more visibility of this PR. |
reopening this in another PR to run properly the tests |
What change does this PR introduce?
This PR updates the project to use Node 18 everywhere.
Why was this change needed?
Closes #1959
The only currently supported version, Node 16 LTS has it's end-of-life on September 11th 2023, about three weeks away now.
Other information (Screenshots)
Probably should be discussed if the project should add support up to version 20, which is currently active and will become LTS soon. I will happily make any changes necessary.
All docker container image tag changes have been checked to exist.
Currently this PR sets the node version requirement to
>=18.17.1 <19
, meaning it accepts the current latest LTS patch or a later patch in 18.x, but not versions with a older or a newer major (19, 20).