chore: update to node 18 lts

novuhq · Aug 22, 2023 · 26c2931 · 26c2931
1 parent 981c7be
commit 26c2931
Show file tree

Hide file tree

Showing 33 changed files with 34 additions and 39 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -1,5 +1,5 @@
 # [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 16, 14, 12, 16-bullseye, 14-bullseye, 12-bullseye, 16-buster, 14-buster, 12-buster
-ARG VARIANT=16-bullseye
+ARG VARIANT=18-bullseye
 FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
 
 # Install MongoDB command line tools if on buster and x86_64 (arm64 not supported)
@@ -23,6 +23,3 @@ RUN . /etc/os-release \
 
 # [Optional] Uncomment if you want to install more global node modules
 RUN su node -c "npm install -g [email protected]"
-
-
-
diff --git a/.devcontainer/docker-compose.yml b/.devcontainer/docker-compose.yml
@@ -9,7 +9,7 @@ services:
         # Update 'VARIANT' to pick an LTS version of Node.js: 16, 14, 12.
         # Append -bullseye or -buster to pin to an OS version.
         # Use -bullseye variants on local arm64/Apple Silicon.
-        VARIANT: 16-bullseye
+        VARIANT: 18-bullseye
     volumes:
       - ..:/workspace:cached
 

diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -64,7 +64,7 @@ body:
     attributes:
       label: node version
       description: In case of self-hosting or local installation mention the node version. If using our cloud-managed solution, mention NA.
-      placeholder: 16.0.0
+      placeholder: 18.0.0
   - type: textarea
     id: additional-context
     validations:

diff --git a/.github/actions/setup-project/action.yml b/.github/actions/setup-project/action.yml
@@ -28,7 +28,7 @@ runs:
     - uses: actions/setup-node@v3
       name: ⚙️ Setup Node Version
       with:
-        node-version: '16.15.1'
+        node-version: '18.17.1'
         cache: 'pnpm'
 
     - name: 💵 Start Redis

diff --git a/.github/workflows/community-label.yml b/.github/workflows/community-label.yml
@@ -17,7 +17,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
       - name: Install Octokit
         run: npm --prefix .github/workflows/scripts install @octokit/action
 

diff --git a/.github/workflows/issue-label.yml b/.github/workflows/issue-label.yml
@@ -17,7 +17,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
       - name: Install Octokit
         run: npm --prefix .github/workflows/scripts install @octokit/action
 

diff --git a/.github/workflows/milestone-assign.yml b/.github/workflows/milestone-assign.yml
@@ -21,7 +21,7 @@ jobs:
 
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
       - name: Install Octokit
         run: npm --prefix .github/workflows/scripts install @octokit/action
 

diff --git a/.github/workflows/tag-images.yml b/.github/workflows/tag-images.yml
@@ -26,7 +26,7 @@ jobs:
         run: echo fs.inotify.max_user_watches=524288 | sudo tee -a /etc/sysctl.conf && sudo sysctl -p
       - uses: actions/setup-node@v3
         with:
-          node-version: '16.15.1'
+          node-version: '18.17.1'
 
       - name: Login to docker
         env:
@@ -125,4 +125,3 @@ jobs:
           docker pull ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod
           docker tag ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:prod ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$DOCKER_VERSION
           docker push ghcr.io/$REGISTRY_OWNER/$DOCKER_NAME:$DOCKER_VERSION
-
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-16.15.1
+18.17.1
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -20,7 +20,7 @@ You can open a new issue with this [issue form](https://github.com/novuhq/novu/i
 
 ### Requirements
 
-- Node.js version v14.19.3
+- Node.js version v18.17.1 (LTS)
 - MongoDB
 - Redis. To install Redis on your O.S, please follow the below guides
   - [To install Redis on Windows](https://redis.io/docs/getting-started/installation/install-redis-on-windows/)

diff --git a/_templates/provider/new/package.ejs.t b/_templates/provider/new/package.ejs.t
@@ -34,7 +34,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/apps/api/Dockerfile b/apps/api/Dockerfile
@@ -1,4 +1,4 @@
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine as dev_base
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine as dev_base
 
 ARG BULL_MQ_PRO_TOKEN
 ENV BULL_MQ_PRO_NPM_TOKEN=$BULL_MQ_PRO_TOKEN

diff --git a/apps/inbound-mail/Dockerfile b/apps/inbound-mail/Dockerfile
@@ -1,4 +1,4 @@
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine as dev_base
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine as dev_base
 
 ARG BULL_MQ_PRO_TOKEN
 ENV BULL_MQ_PRO_NPM_TOKEN=$BULL_MQ_PRO_TOKEN

diff --git a/apps/web/Dockerfile b/apps/web/Dockerfile
@@ -1,5 +1,5 @@
 # start build stage
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine as builder
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine as builder
 ENV NX_DAEMON=false
 
 WORKDIR /usr/src/app
@@ -37,7 +37,7 @@ RUN NX_DAEMON=false pnpm build:web
 # end build stage
 
 # start production stage
-FROM node:16-alpine
+FROM node:18-alpine
 
 WORKDIR /app
 

diff --git a/apps/webhook/Dockerfile b/apps/webhook/Dockerfile
@@ -1,4 +1,4 @@
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine as dev_base
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine as dev_base
 ENV NX_DAEMON=false
 
 RUN npm i pm2 -g

diff --git a/apps/widget/Dockerfile b/apps/widget/Dockerfile
@@ -1,4 +1,4 @@
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine
 ENV NX_DAEMON=false
 
 WORKDIR /usr/src/app

diff --git a/apps/worker/Dockerfile b/apps/worker/Dockerfile
@@ -1,4 +1,4 @@
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine as dev_base
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine as dev_base
 RUN apk --update --no-cache add curl
 ENV NX_DAEMON=false
 

diff --git a/apps/ws/Dockerfile b/apps/ws/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-alpine3.16
+FROM node:18-alpine3.16
 
 ARG BULL_MQ_PRO_TOKEN
 ENV BULL_MQ_PRO_NPM_TOKEN=$BULL_MQ_PRO_TOKEN

diff --git a/docs/docs/community/create-provider.md b/docs/docs/community/create-provider.md
@@ -13,7 +13,7 @@ Providers allow us to handle message delivery over multiple channels. We have mu
 
 ## Requirements
 
-- Node.js version v16.15.1
+- Node.js version v18.17.1
 - MongoDB
 - Redis
 - **(Optional)** pnpm - Needed if you want to install new packages

diff --git a/docs/docs/community/faq.md b/docs/docs/community/faq.md
@@ -10,7 +10,7 @@ Here we will outline some of the most common questions we get asked about the pr
 
 Novu consists of multiple services written in Node.js and Typescript. The following are the dependencies required to run the project fully:
 
-- Node.js version v16.15.1
+- Node.js version v18.17.1
 - MongoDB
 - Redis
 - File storage (S3/GCP/Azure) - Optional

diff --git a/docs/docs/community/run-locally.md b/docs/docs/community/run-locally.md
@@ -13,7 +13,7 @@ import FAQItem from '@site/src/components/FAQItem';
 
 ## Requirements
 
-- Node.js version v16.15.1
+- Node.js version v18.17.1
 - MongoDB
 - Redis
 - **(Optional)** pnpm - Needed if you want to install new packages

diff --git a/libs/embed/Dockerfile b/libs/embed/Dockerfile
@@ -1,4 +1,4 @@
-FROM nikolaik/python-nodejs:python3.10-nodejs16-alpine
+FROM nikolaik/python-nodejs:python3.10-nodejs18-alpine
 
 WORKDIR /usr/src/app
 

diff --git a/package.json b/package.json
@@ -187,7 +187,7 @@
     }
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.33.4"
   },
   "dependencies": {

diff --git a/providers/africas-talking/package.json b/providers/africas-talking/package.json
@@ -30,7 +30,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/forty-six-elks/package.json b/providers/forty-six-elks/package.json
@@ -29,7 +29,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/maqsam/package.json b/providers/maqsam/package.json
@@ -29,7 +29,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/mattermost/package.json b/providers/mattermost/package.json
@@ -29,7 +29,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/one-signal/package.json b/providers/one-signal/package.json
@@ -30,7 +30,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/plunk/package.json b/providers/plunk/package.json
@@ -29,7 +29,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/push-webhook/package.json b/providers/push-webhook/package.json
@@ -30,7 +30,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/sendchamp/package.json b/providers/sendchamp/package.json
@@ -29,7 +29,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/providers/sms-central/package.json b/providers/sms-central/package.json
@@ -29,7 +29,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=13.0.0 <17.0.0",
+    "node": ">=18.17.1 <19",
     "pnpm": "^7.26.0"
   },
   "dependencies": {

diff --git a/scripts/dev-environment-setup.sh b/scripts/dev-environment-setup.sh
@@ -261,7 +261,7 @@ check_nvm () {
 }
 
 install_node () {
-    NODE_JS_VERSION="v16.15.1"
+    NODE_JS_VERSION="v18.17.1"
 
     SKIP="$(check_nvm)"
 
@@ -512,4 +512,3 @@ install_os_dependencies () {
 install_os_dependencies
 clone_monorepo
 refresh_shell
-