Bundle cjs and esm #214
Open
Bundle cjs and esm #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to make thigs work with both Node and browser I have to add Additionally lodash deps has been changed to ESM dependency and updated imports to make it work in ESM |
|
Also I had to disable tslint because it was complaining (prettier) about both CR/CRLF. It was again non-fixable in reasonable time. Can you consider migrating to eslint and run prettier on commit ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193
Changes proposed in this pull request:
Bundle both cjs and esm making a few changes as possible.
Reviewers should focus on:
Confirming the new bundle works in both cjs and esm projects.