-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ES Modules output, make BlueprintJS dependency explicit #149
base: master
Are you sure you want to change the base?
Conversation
This is super useful I appreciate it. Will definitely look into picking some of these changes over to master although I have very little time nowadays to spend on this project so it may be a while. Thanks for sharing! |
Does this need to be updated? We need this too and this issue has been around since 2020 and last touched in 2022. |
I suggest you to use react-resizable-panels instead |
Have you seen anywhere where panels were able to be dragged to re-arrange w/ react-resizable-panels? The DND functionality has to be the most bug-prone part of implementing something like this and I don't see any hint of it in their demo. |
Can somebody merge it? |
@nomcopter Seems like this PR is too old, so I create my own, could you please review? |
I recently started using react-mosaic in a project with Snowpack. These are the changes I made to get it working.
I added ES module generation via
tsc
, and removed therequire.resolve
calls, because some deployments aren't going to have that available. There is a tradeoff there with pulling in a dependency that not everyone will necessarily use if they want their own styles.I also updated various packages to get it working in the browser with ESM not webpack.
These changes don't affect any functionality, and these features may not be a high priority for the maintainers. I just thought you may want to be aware and maybe pick and choose some of my additions.
Thanks for a great project!