fix: fix aria-hidden on hidden icons (#957)

nolanlawson · Feb 10, 2019 · 56f5a45 · 56f5a45
1 parent 2884955
commit 56f5a45
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/routes/_components/IconButton.html b/src/routes/_components/IconButton.html
@@ -3,6 +3,7 @@
           title={label}
           aria-label={label}
           aria-pressed={pressable ? !!pressed : void 0}
+          aria-hidden={ariaHidden}
           class={computedClass}
           {disabled}
           delegate-key={delegateKey}
@@ -16,6 +17,7 @@
           title={label}
           aria-label={label}
           aria-pressed={pressable ? !!pressed : void 0}
+          aria-hidden={ariaHidden}
           class={computedClass}
           focus-key={focusKey || ''}
           {disabled}
@@ -117,7 +119,8 @@
       pressed: false,
       className: void 0,
       delegateKey: void 0,
-      sameColorWhenPressed: false
+      sameColorWhenPressed: false,
+      ariaHidden: false
     }),
     store: () => store,
     computed: {

diff --git a/src/routes/_components/dialog/components/MediaDialog.html b/src/routes/_components/dialog/components/MediaDialog.html
@@ -29,6 +29,7 @@
           className="media-control-button media-control-button-dummy-spacer"
           href="#fa-search"
           label=""
+          ariaHidden={true}
         />
       {/if}
       {#if dots.length > 1}

diff --git a/src/routes/_components/dialog/components/PinchZoomable.html b/src/routes/_components/dialog/components/PinchZoomable.html
@@ -8,13 +8,15 @@
     label="Zoom out"
     href="#fa-search-minus"
     on:click="zoomOut()"
+    ariaHidden={disabled}
   />
   <IconButton
     className="pinch-zoom-button pinch-zoom-button-zoom-in"
     muted={true}
     label="Zoom in"
     href="#fa-search-plus"
     on:click="zoomIn()"
+    ariaHidden={disabled}
   />
 </div>
 <style>