fix: carousel should use ul/li for a11y (#956)

nolanlawson · Feb 10, 2019 · 2884955 · 2884955
1 parent 9cb15a3
commit 2884955
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/routes/_components/dialog/components/MediaDialog.html b/src/routes/_components/dialog/components/MediaDialog.html
@@ -6,9 +6,9 @@
   className="media-modal-dialog"
 >
   <div class="media-container">
-    <div class="media-scroll" ref:scroller>
+    <ul class="media-scroll" ref:scroller>
       {#each mediaItems as media}
-        <div class="media-scroll-item">
+        <li class="media-scroll-item">
           <div class="media-scroll-item-inner">
             <div class="media-scroll-item-inner-inner">
                 {#if canPinchZoom}
@@ -20,9 +20,9 @@
                 {/if}
             </div>
           </div>
-        </div>
+        </li>
       {/each}
-    </div>
+    </ul>
     <div class="media-controls-outside">
       {#if canPinchZoom}
         <IconButton
@@ -98,6 +98,12 @@
     -ms-overflow-style: none;
   }
 
+  ul.media-scroll {
+    padding: 0;
+    margin: 0;
+    list-style: none;
+  }
+
   .media-scroll::-webkit-scrollbar {
     display: none;
   }