Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Vite 6 #417

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Bump to Vite 6 #417

merged 5 commits into from
Dec 2, 2024

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Nov 26, 2024

Finally, the vite 6 is out

https://github.com/vitejs/vite/blob/v6.0.0/packages/vite/CHANGELOG.md

I know it'll probably trigger a larger refactor of Vinxi to use the Env API, but in the meantime it would be nice to land these improvements in solid start etc.

Copy link

codesandbox bot commented Nov 26, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: 28a23e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
vinxi Minor
@vinxi/plugin-directives Major
@vinxi/react-server Patch
@vinxi/router Major
@vinxi/server-components Major
@vinxi/server-functions Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vinxi-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 10:57pm

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@birkskyum
Copy link
Contributor Author

birkskyum commented Nov 26, 2024

I added as a major, just to avoid breaking anything that updates automatically.

Copy link

pkg-pr-new bot commented Nov 26, 2024

Open in Stackblitz

@vinxi/deno-doc

npm i https://pkg.pr.new/@vinxi/deno-doc@417

vinxi

npm i https://pkg.pr.new/vinxi@417

@vinxi/plugin-directives

npm i https://pkg.pr.new/@vinxi/plugin-directives@417

@vinxi/plugin-mdx

npm i https://pkg.pr.new/@vinxi/plugin-mdx@417

@vinxi/doc

npm i https://pkg.pr.new/@vinxi/doc@417

@vinxi/openapi

npm i https://pkg.pr.new/@vinxi/openapi@417

@vinxi/react

npm i https://pkg.pr.new/@vinxi/react@417

@vinxi/react-server

npm i https://pkg.pr.new/@vinxi/react-server@417

@vinxi/router

npm i https://pkg.pr.new/@vinxi/router@417

@vinxi/server-components

npm i https://pkg.pr.new/@vinxi/server-components@417

@vinxi/server-functions

npm i https://pkg.pr.new/@vinxi/server-functions@417

@vinxi/solid

npm i https://pkg.pr.new/@vinxi/solid@417

commit: 28a23e1

@nksaraf
Copy link
Owner

nksaraf commented Dec 1, 2024

Do we know why the builds might be failing? if we can debug that, we are good to go, I don't think there are any big breaking changes in vite 6 as far as I know.

@nksaraf
Copy link
Owner

nksaraf commented Dec 1, 2024

We don't want to go 1.0, yet, this will have be a minor (also there aren't really any big changes), until we actually integrate the environments API, then we can go to 1.0, I feel like there could be some API changes on our side when we do that.

@nksaraf nksaraf merged commit 69317b7 into nksaraf:main Dec 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants