Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to vinxi 0.5 (vite 6) #1682

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Upgrade to vinxi 0.5 (vite 6) #1682

merged 2 commits into from
Dec 3, 2024

Conversation

birkskyum
Copy link
Contributor

@birkskyum birkskyum commented Dec 2, 2024

Continuation of

This updates the vinxi and vite version in the root and /packages/start.

Despite packages/start 1.0.10 using the @vinxi 0.4.3 packages below, it does appear to be compatible with vinxi 0.5.0, but this pr aligns it all on the same vinxi 0.5.0 version:

"@vinxi/plugin-directives": "^0.4.3",
"@vinxi/server-components": "^0.4.3",
"@vinxi/server-functions": "^0.4.3".

Examples can be updated only after the release is cut, because they don't use "workspace:*" (due to create-solid).

I tested this by building locally and updated the with-vitest example, which works for ssr:true/false, and vinxi dev/build/start

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 1945af4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid
Copy link
Member

ok yeah.. I will do a few local tests. But lets get this minor out.

@ryansolid ryansolid merged commit 0676fbf into solidjs:main Dec 3, 2024
4 checks passed
@ryansolid
Copy link
Member

ryansolid commented Dec 3, 2024

Yeah I merged this as my examples all worked. But there is definitely FOUC in dev again. Probably from latest Vinxi release. We need confirm it is coming from there I suppose before we can release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants