Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL: 1.1.9 #2884

Merged
merged 14 commits into from
Feb 25, 2019
Merged

REL: 1.1.9 #2884

merged 14 commits into from
Feb 25, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Feb 22, 2019

Summary

Prep for 1.1.9 release, targeting Monday, Feberuary 25.

Pending merge or postponement decision on:

Just a note that I don't consider any of these blocking, so if I don't hear from their authors by tomorrow evening I will remove the milestone. Feel free to set it to 1.2.0 if you think you can come back to it in the next month, or future if you still plan to come back to it, but don't foresee hitting next month's deadline. Older/inactive PRs may be deemed orphaned.

Release checklist

  • Update changelog
  • Update .mailmap
  • Update .zenodo.json
  • Set release number in nipype/info.py and doc/conf.py
  • Update doc/documentation.rst with previous releases
  • Tutorial tests (@djarecka)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member Author

effigies commented Feb 22, 2019

The following contributors since 1.1.8 do not have entries in the .zenodo.json:

Please add yourselves, if you're interested.

From a scan through the full shortlog, I also notice the following people don't have entries:

If any of you would like to be listed properly as authors, please add your information to the Zenodo file. Or just post the name you'd like to be cited with, your affiliation and your ORCID, and I'll add you.

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #2884 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
- Coverage   67.51%   67.48%   -0.03%     
==========================================
  Files         343      343              
  Lines       43598    43598              
  Branches     5426     5426              
==========================================
- Hits        29436    29424      -12     
- Misses      13459    13462       +3     
- Partials      703      712       +9
Flag Coverage Δ
#smoketests 50.43% <100%> (-0.04%) ⬇️
#unittests 64.9% <100%> (-0.05%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 89.39% <100%> (-4.55%) ⬇️
nipype/pipeline/plugins/legacymultiproc.py 61.5% <0%> (-4.5%) ⬇️
nipype/interfaces/io.py 55.07% <0%> (ø) ⬆️
nipype/interfaces/freesurfer/preprocess.py 66.11% <0%> (ø) ⬆️
nipype/interfaces/dynamic_slicer.py 17.47% <0%> (ø) ⬆️
nipype/interfaces/nipy/preprocess.py 45.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6071c94...5ced29f. Read the comment docs.

@effigies effigies added this to the 1.1.9 milestone Feb 22, 2019
@effigies effigies mentioned this pull request Feb 24, 2019
1 task
@effigies effigies mentioned this pull request Feb 25, 2019
1 task
@anibalsolon anibalsolon mentioned this pull request Feb 25, 2019
1 task
@kchawla-pi
Copy link
Contributor

Name: Kshitij Chawla (kchawla-pi)
Affiliation: INRIA-Saclay, Team Parietal
ORCID: 0000-0002-7517-6321

@effigies
Copy link
Member Author

Thanks @kchawla-pi.

@effigies
Copy link
Member Author

@qtabs @gladomat We have a script that reorders Zenodo entries by lines contributed, and it looks like it removed Paul's entry. I checked the shortlog and don't see him as the author on any commits? Could you clarify the contribution? If he's been a co-author, but all the commits were authored by Alejandro, I can add him to a list of authors who get appended just prior to the last author (we have a few of these whose apparent contributions have disappeared due to reorganizations).

@qtabs
Copy link
Contributor

qtabs commented Feb 25, 2019

@qtabs @gladomat We have a script that reorders Zenodo entries by lines contributed, and it looks like it removed Paul's entry. I checked the shortlog and don't see him as the author on any commits? Could you clarify the contribution? If he's been a co-author, but all the commits were authored by Alejandro, I can add him to a list of authors who get appended just prior to the last author (we have a few of these whose apparent contributions have disappeared due to reorganizations).

Yes, sorry! Although I pushed the commits we worked together in the implementation. Can you please add him to the appended list? I don't think he cares about the ordering too much. Thanks :).

@servoz
Copy link
Collaborator

servoz commented Feb 25, 2019

Name: Eric Condamine (servoz)
Affiliation: CNRS, UMS3552 IRMaGe
ORCID: 0000-0002-9533-3769

@62442katieb
Copy link
Contributor

Name: Katherine Bottenhorn (62442katieb)
Affiliation: Florida International University
ORCID: 0000-0002-7796-8795

@effigies effigies merged commit 08d7092 into master Feb 25, 2019
@effigies effigies deleted the rel/1.1.9 branch February 25, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants