Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate BUSCO to nf-core module #730

Open
wants to merge 22 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### `Added`

- [#730](https://github.com/nf-core/mag/pull/730) - Migrated from local BUSCO module to nf-core one (added by @dialvarezs)

### `Changed`

### `Fixed`

### `Dependencies`

### `Dependencies`
| Tool | Previous version | New version |
| ----- | ---------------- | ----------- |
| BUSCO | 5.4.3 | 5.8.2 |
| csvtk | | 0.30.0 |

### `Deprecated`

- [#730](https://github.com/nf-core/mag/pull/730) - Deprecated `--busco_clean` due to not being supported in the nf-core BUSCO module

## 3.3.0 [2024-12-19]

Expand Down
9 changes: 7 additions & 2 deletions bin/combine_tables.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import argparse
import sys
import warnings

import pandas as pd

Expand Down Expand Up @@ -110,10 +111,14 @@ def main(args=None):

if args.binqc_summary and args.binqc_tool == "busco":
busco_results = pd.read_csv(args.binqc_summary, sep="\t")
if not bins.equals(busco_results["GenomeBin"].sort_values().reset_index(drop=True)):
busco_bins = set(busco_results["Input_file"])

if set(bins) != busco_bins and len(busco_bins.intersection(set(bins))) > 0:
warnings.warn("Bins in BUSCO summary do not match bins in bin depths summary")
elif len(busco_bins.intersection(set(bins))) == 0:
sys.exit("Bins in BUSCO summary do not match bins in bin depths summary!")
results = pd.merge(
results, busco_results, left_on="bin", right_on="GenomeBin", how="outer"
results, busco_results, left_on="bin", right_on="Input_file", how="outer"
) # assuming depths for all bins are given

if args.binqc_summary and args.binqc_tool == "checkm":
Expand Down
166 changes: 0 additions & 166 deletions bin/run_busco.sh

This file was deleted.

Loading
Loading