Fix languageserver errors #726
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,15 +16,15 @@ include { FASTA_BINNING_CONCOCT } from '../../subworkflows/nf-co | |||
| workflow BINNING { | |||
| take: | |||
| assemblies // channel: [ val(meta), path(assembly), path(bams), path(bais) ] | |||
| reads // channel: [ val(meta), [ reads ] ] | |||
| _reads // channel: [ val(meta), [ reads ] ] | |||
There was a problem hiding this comment.
If this isn't used in the workflow at all, remove from the workflow inputs?
There was a problem hiding this comment.
You're right, I guess it makes more sense to remote it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves errors/warings reported by the Nextflow language server.
Mostly reused variable names and unused variables.
Question
Should we also consider formatting the code using the language server's formatter? I believe this could help standardize the code style, but I’m not entirely sure.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).