Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unused CATALOG_ID and CATALOG_SECRET #197

Merged
merged 1 commit into from
Nov 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ services:
- LDAP_SERVER_URI=${LDAP_SERVER_URI}
- LDAP_DOMAIN_COMPONENT=${LDAP_DOMAIN_COMPONENT}
- CATALOG_URL=${CATALOG_URL}
- CATALOG_ID=${CATALOG_ID}
- CATALOG_SECRET=${CATALOG_SECRET}
- CATALOG_API_TOKEN=${CATALOG_API_TOKEN}
- GUNICORN_CMD_ARGS=--reload --workers=8
- REQUESTS_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt
Expand Down
7 changes: 3 additions & 4 deletions docs/developer/instruction/build.rst
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ been initialized:
LDAP_USER_DN_TEMPLATE=*****
LDAP_DOMAIN_COMPONENT=*****
CATALOG_URL=*****
CATALOG_ID=*****
CATALOG_SECRET=*****
CATALOG_API_TOKEN=*****

It is recommended to store these variables in an ``.envrc`` file and manage their loading/unloading
into the shell with the `direnv <direnv/>`_ command-line utility.
Expand All @@ -121,8 +120,8 @@ The environment variables ``LDAP_SERVER_URI`` and ``LDAP_DOMAIN_COMPONENT`` are
Senior developers can provide the values to use,
then the developer setup can work with Neutron Scattering Division's (NSD) LDAP instance.

The environment variables ``CATALOG_URL``, ``CATALOG_ID`` and
``CATALOG_SECRET`` can be set to allow run metadata to be retrieved
The environment variables ``CATALOG_URL`` and ``CATALOG_API_TOKEN``
can be set to allow run metadata to be retrieved
from `ONCat <https://oncat.ornl.gov>`_.

Special users
Expand Down
3 changes: 1 addition & 2 deletions docs/developer/instruction/deployment.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ Variable Secret Description
====================== ====== ===========
AMQ_BROKER List of ActiveMQ brokers
APP_SECRET yes `Django SECRET_KEY <https://docs.djangoproject.com/en/3.2/ref/settings/#secret-key>`_
CATALOG_ID yes `ONCat client ID <https://oncat.ornl.gov/#/build?section=authentication>`_
CATALOG_SECRET yes `ONCat client secret <https://oncat.ornl.gov/#/build?section=authentication>`_
CATALOG_URL yes `ONCat URL <https://oncat.ornl.gov>`_
CATALOG_API_TOKEN yes `ONCat API token <https://oncat.ornl.gov>`_
DATABASE_HOST PostgreSQL hostname
DATABASE_NAME Database name
DATABASE_PASS yes PostgreSQL Owner password
Expand Down
2 changes: 0 additions & 2 deletions src/webmon_app/reporting/reporting_app/settings/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ def validate_ldap_settings(server_uri, user_dn_template):

# ONCat Catalog
CATALOG_URL = environ.get("CATALOG_URL")
CATALOG_ID = environ.get("CATALOG_ID")
CATALOG_SECRET = environ.get("CATALOG_SECRET")
CATALOG_API_TOKEN = environ.get("CATALOG_API_TOKEN")

# The DB settings are defined the same as in the workflow manager
Expand Down
3 changes: 1 addition & 2 deletions src/webmon_app/reporting/reporting_app/settings/unittest.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
DEBUG = True

CATALOG_URL = "catalog.test.xyz"
CATALOG_ID = "test"
CATALOG_SECRET = "test"
CATALOG_API_TOKEN = "test"

del CACHES # noqa: F821

Expand Down
Loading