Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now unused CATALOG_ID and CATALOG_SECRET #197

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Nov 20, 2024

Description of the changes

WebMon was actually moved to using the API token in #195, this just cleans up the remaining parts.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.78%. Comparing base (5d250e6) to head (41e7b14).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #197      +/-   ##
==========================================
- Coverage   77.79%   77.78%   -0.02%     
==========================================
  Files          54       54              
  Lines        4711     4708       -3     
==========================================
- Hits         3665     3662       -3     
  Misses       1046     1046              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rosswhitfield rosswhitfield marked this pull request as ready for review November 20, 2024 03:30
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@backmari backmari merged commit b7304ff into next Nov 20, 2024
4 checks passed
@backmari backmari deleted the update_oncat_varibles branch November 20, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants