Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cibuildwheel #90

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Remove cibuildwheel #90

merged 1 commit into from
Nov 9, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Nov 9, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We don't want to have cibuildwheel by default.

What does this PR do?

Removes options for cibuildwheel from pyproject.toml

References

Closes #81, depends on #89

How has this PR been tested?

Searched all files for occurrences of cibuildwheel and removed. Existing tests pass. Not sure how to easily do more than that?

Is this a breaking change?

In theory, yes, if projects that need cibuildwheel rely on this being here?

Does this PR require an update to the documentation?

AFAICT cibuildwheel was not documented here anyway, so no.

Checklist:

  • [NA] The code has been tested locally
  • [NA] Tests have been added to cover all new functionality
  • [NA] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder changed the title drop 3.8, add 3.11 in template pyproject Remove cibuildwheel Nov 9, 2023
@alessandrofelder alessandrofelder marked this pull request as ready for review November 9, 2023 13:53
@adamltyson adamltyson merged commit 482773d into main Nov 9, 2023
12 checks passed
@adamltyson adamltyson deleted the remove-cibuildwheel branch November 9, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cibuildwheel config?
2 participants