Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop 3.8 support, add 3.11 #88

Merged
merged 3 commits into from
Nov 9, 2023
Merged

drop 3.8 support, add 3.11 #88

merged 3 commits into from
Nov 9, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Nov 9, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

We'd like to move to supporting python 3.11.

What does this PR do?

Drops Python 3.8 and adds 3.11 instead in pyproject.toml and GH actions workflow.

References

Closes #38

How has this PR been tested?

Checks in CI and locally on my Silicon Mac.

Is this a breaking change?

If you're using 3.8, yes.

Does this PR require an update to the documentation?

It's already documented that we follow NEP 29, so no.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review November 9, 2023 12:45
@alessandrofelder alessandrofelder requested a review from a team November 9, 2023 12:45
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@IgorTatarnikov IgorTatarnikov merged commit 7d2339f into main Nov 9, 2023
13 checks passed
@adamltyson
Copy link
Member

@alessandrofelder I don't think this has changed the cookiecutter template itself.

@alessandrofelder
Copy link
Member Author

Yep @adamltyson I just noticed too - I'll fix now.

This was referenced Nov 9, 2023
@alessandrofelder alessandrofelder deleted the nep-29 branch November 9, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.11
3 participants