Add wheel as dependency to check-manifest

[sfmig]

Problem

With Python 3.12, pre-commit run check-manifest returns an error of missing dependencies.

According to this issue this is due to a change in behaviour in Python 3.12, in which apparently wheel is no longer preinstalled with virtualenv / venv. See release notes too.

Proposed solution

Option 1: adding wheel as an additional dependency in .pre-commit-config.yaml. This is implemented in this PR.

  - repo: https://github.com/mgedmin/check-manifest
    rev: "0.49"
    hooks:
        - id: check-manifest
          args: [--no-build-isolation]
          additional_dependencies: [setuptools-scm, wheel]

Option 2: specifying a language version for Python in check-manifest. Feels less flexible.

  - repo: https://github.com/mgedmin/check-manifest
    rev: "0.49"
    hooks:
        - id: check-manifest
          args: [--no-build-isolation]
          language_version: "3.12"
          additional_dependencies: [setuptools-scm]

Questions

• In CI, we run check-manifest with Python 3.10 and without the --no-build-isolation flag.

• Do we need to make CI and the pre-commit hook more similar? Why do we run the --no-build-isolation flag in the pre-commits?

• This is only a problem if the system or python interpreter in the same environment as the pre-commit tool is 3.12, so not sure if we should fix this already?

[adamltyson]

Option 1 sounds sensible to me