Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest fail when warnings are raised #111

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Pytest fail when warnings are raised #111

merged 1 commit into from
Feb 20, 2024

Conversation

adamltyson
Copy link
Member

Closes #46

@adamltyson adamltyson requested a review from a team February 20, 2024 17:38
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit worried by this one. Should we document this somewhere (e.g. as a comment in pyproject.toml or in the README)? Perhaps we can link the pytest guide for capturing and controlling warnings that David mentioned. Otherwise, people will be perplexed and left without recourse when this first happens.

@adamltyson
Copy link
Member Author

I thought about adding docs for this, but I realised that the docs don't cover pytest issues at all. If users use pytest, then they're on their own if any issues come up, not just this.

Realistically, I think we should tackle #36 and add some real docs about what each of the components do.

@niksirbi
Copy link
Member

Realistically, I think we should tackle #36 and add some real docs about what each of the components do.

Agreed, but I'm afraid this will be a multi-day chunk of work. Anyhow, I'm going to approve and merge this one as is.

@niksirbi niksirbi merged commit fb1469a into main Feb 20, 2024
13 checks passed
@adamltyson adamltyson deleted the pytest branch February 20, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add config to error when warnings raised during tests
2 participants